Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sample implementation of car-optimized settings to UAMP #323

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add sample implementation of car-optimized settings to UAMP #323

wants to merge 4 commits into from

Conversation

rampara
Copy link
Contributor

@rampara rampara commented Jan 31, 2020

No description provided.

nic0lette
nic0lette requested changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@nic0lette nic0lette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some brief/trivial comments on some files.

There are also missing license headers missing, so they should be added as well.

...-lib/src/androidTest/java/com/example/android/uamp/automotive/lib/ExampleInstrumentedTest.kt Outdated Show resolved Hide resolved
...otive/automotive-lib/src/main/java/com/example/android/uamp/automotive/lib/ListPreference.kt Outdated Show resolved Hide resolved
...otive/automotive-lib/src/main/java/com/example/android/uamp/automotive/lib/ListPreference.kt Outdated Show resolved Hide resolved
...otive-lib/src/main/java/com/example/android/uamp/automotive/lib/MultiSelectListPreference.kt Outdated Show resolved Hide resolved
@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 18:04
@dturner dturner self-assigned this Dec 4, 2020
@dturner dturner added this to the Next milestone Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic0lette nic0lette nic0lette requested changes

@dturner dturner Awaiting requested review from dturner

Assignees

@dturner dturner

Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
3 participants
@rampara @nic0lette @dturner