[SplashScreen] Add a new sample #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ieb43b88302a449778828da81e8bee64d4652d480
Change-Id: I01a68c0c100138b91f4a7cafa9c84b9e1978c8ec
chrisbanes
reviewed
Apr 22, 2021
SplashScreen/app/build.gradle
Outdated
| implementation 'androidx.activity:activity-ktx:1.3.0-alpha05' | ||
| implementation 'androidx.appcompat:appcompat:1.3.0-beta01' | ||
| implementation 'com.google.android.material:material:1.3.0' | ||
| implementation 'androidx.constraintlayout:constraintlayout:2.0.4' |
| // duration of the app launch, the animation might not have finished yet. We can | ||
| // calculate the remaining duration of the icon animation as follows. | ||
| val remainingDuration = ( | ||
| splashScreenView.iconAnimationDurationMillis - |
There was a problem hiding this comment.
This looks a bit weird to me. Can this be extracted to an ext-val?
There was a problem hiding this comment.
Extracted the calculation and added comments about each of the involved values.
| setContentView(binding.root) | ||
| setSupportActionBar(binding.toolbar) | ||
| // Suspend drawing the app content until the initial data is ready. | ||
| suspendDraw() |
There was a problem hiding this comment.
I'd call this suppressDraw() instead. suspend makes me think of coroutines.
| init { | ||
| viewModelScope.launch { | ||
| val nightMode = withContext(Dispatchers.IO) { | ||
| prefs.getInt(PREF_NIGHT_MODE, UiModeManager.MODE_NIGHT_AUTO) |
There was a problem hiding this comment.
I think getSharedPreferences() should probably be done in the bg too
There was a problem hiding this comment.
Done. It is now in a background thread.
- Remove an unnecessary dependency of ConstraintLayout. - Improve handling of SharedPreferences. - suspendDraw is now supressDraw - Extract calculation of remaining duration of animation. Change-Id: I006f9fc1f930f85fee46d4e3e3dbaf03cbe63d59
chrisbanes
approved these changes
Apr 22, 2021
|
Yes, it was 172330 internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ieb43b88302a449778828da81e8bee64d4652d480