Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datalayer improvements #1105

Merged
merged 2 commits into from
May 28, 2024
Merged

Datalayer improvements #1105

merged 2 commits into from
May 28, 2024

Conversation

kul3r4
Copy link
Contributor

@kul3r4 kul3r4 commented May 23, 2024

Various improvements on the Wear app:

  • Uses Horologist for AppScaffold and ScreenScaffold: this allows to remove handling of TimeText and PositionIndicator.
  • Removes vignette
  • Removes mentioning NodeClient which is not used, only CapabilityClient is used for discovery
  • Adds adaptive icons (also on the phone app so that they match)
  • Uses Chips instead of buttons
  • Uses latest Preview lib

@kul3r4 kul3r4 requested review from yschimke and garanj May 23, 2024 15:36
garanj
garanj reviewed May 24, 2024
View reviewed changes
WearSpeakerSample/README.md Outdated
@@ -9,6 +9,11 @@ play the recorded voice, if the wearable device is connected to a speaker

This sample is also written entirely with Jetpack Compose, using [Wear-specific components provided
by AndroidX](https://developer.android.com/jetpack/androidx/releases/wear-compose).
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some merge remnants here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

garanj
garanj approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@garanj garanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I added one small comment about one of the READMEs

@kul3r4 kul3r4 force-pushed the datalayer-improve branch from 9986a9a to ca68780 Compare May 24, 2024 14:44
@kul3r4 kul3r4 force-pushed the datalayer-improve branch from ca68780 to af89f1a Compare May 28, 2024 14:23
@kul3r4 kul3r4 merged commit 4cc99c7 into android:main May 28, 2024
5 checks passed
@kul3r4
Copy link
Contributor Author

kul3r4 commented Jun 10, 2024

Related to #1039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garanj garanj garanj approved these changes

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kul3r4 @yschimke @garanj