Optional param for I2C address in constructor #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
proppy
requested changes
Jan 9, 2017
| @@ -41,6 +41,7 @@ | |||
| * I2C address for this peripheral | |||
| */ | |||
| public static final int I2C_ADDRESS = 0x3C; | |||
| public static final int I2C_ADDRESS_SECONDARY = 0x3D; | |||
| /** | ||
| * Create a new Ssd1306 driver connected to the named I2C bus and address | ||
| * @param i2cName I2C bus name the display is connected to | ||
| * @param i2cAddress I2C address the display is connected to |
There was a problem hiding this comment.
nit: I2C address of the display
|
@proppy I've addressed all three of your comments. Thanks! |
proppy
approved these changes
Jan 9, 2017
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing with a board I made featuring two of these ssd1306 oled screens on it. The version I have can have it's I2C address changed by bridging two contacts on the back, allowing there to be two separate screens to draw to simultaneously.
This pr adds another constructor that takes a given I2C address to communicate with. The existing constructor defaults to the address that was already in place.