This repository was archived by the owner on Dec 27, 2024. It is now read-only.
Make ConstraintLayout an inline composable #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with how most layouts in foundation-layout are implemented. In addition, it implicitly fixes issue 181717954, which was happening because the content lambda could previously be recomposed without recomposing the parent content lambda given to MultiMeasureLayout - therefore, the scope was not reset() but it was added the barrier again causing unexpected behavior. Fixes: 181717954 Test: ConstraintLayoutTest
camaelon
approved these changes
Mar 24, 2021
|
Wow, many thanks for fixing 181717954. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with how most layouts in foundation-layout are
implemented. In addition, it implicitly fixes issue 181717954, which was
happening because the content lambda could previously be recomposed
without recomposing the parent content lambda given to
MultiMeasureLayout - therefore, the scope was not reset() but it was
added the barrier again causing unexpected behavior.
Fixes: 181717954
Test: ConstraintLayoutTest