-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing SNTP client timeout #1540
Labels
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Jul 15, 2024
Added a method to set the timeout for the SNTP request. Also changed the default timeout to 5s instead of 10s as it seemed quite high. Issue: #1540 PiperOrigin-RevId: 652566008
copybara-service bot
pushed a commit
that referenced
this issue
Jul 16, 2024
Changed the default timeout for SNTP requests to 1 second. Issue: #1540 PiperOrigin-RevId: 652897579
Hi @jrocharodrigues, We have added changes to allow changing SNTP client timeout and retrying alternative addresses. Thank you for reporting this issue and feel free to reopen this issue in case you have any more questions / suggestions. |
Hi @rohitjoins , Thanks for the fast response and fix. Best regards |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[REQUIRED] Use case description
We started seeing some high video start times (~10 seconds) in our live stream app. After some investigation we found out the problem was that due to some problem in their network, the request to the SNTP server to resolve the time offset was timing out, and this exception was thrown:
After some digging, we found out the problem was due to the client could not reach the sntp server (time.android.com) with IPv6.
Changing the server to one without IPv6, or disabling IPv6 on the client network would solve the problem.
Proposed solution
It would be great if exoplayer allowed to change the timeout of the sntp request, because the default, 10 seconds, seems to high for a non critical request.
It would also be nice if the exoplayer SNTP client would follow the protocol and attempt the alternative ipAddresses in case of failure, which would also solve the problem we we're having due to IPv6 connectivity problems.
Thanks in advance for your support
Best regards
The text was updated successfully, but these errors were encountered: