Rtp h263 test and fix #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I43dfbabcbe686c31cb54e6b95688af1fa35a3d24
Change-Id: I57d57881ef5c158d41be1bf1e3714332d50cd3a9
claincly
requested changes
Jul 14, 2022
...es/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/reader/RtpH263ReaderTest.java
Show resolved
Hide resolved
...es/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/reader/RtpH263ReaderTest.java
Outdated
Show resolved
Hide resolved
Earlier, the consume method of RtpH263Reader was changing the bytes of the input bitstream during header parse. This commit copies the input into local context and changes the local variable as per the specifications thus keeping the input constant.
This reverts commit 3bacb16.
This change is done to keep the frame data unchanged. RtpH263Reader changes the header data in input, so to send the same RTP packet across multiple tests, each test copies the frame data into a new packet and sends that to the reader.
|
Merged internally. |
marcbaechinger
pushed a commit
that referenced
this pull request
Sep 30, 2022
PiperOrigin-RevId: 463146426
microkatz
pushed a commit
that referenced
this pull request
Nov 22, 2022
PiperOrigin-RevId: 463146426 (cherry picked from commit e54d2f5)
icbaker
pushed a commit
that referenced
this pull request
Dec 12, 2022
PiperOrigin-RevId: 463146426 (cherry picked from commit 92fc065)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.