Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RTSP VP9 #64

Closed
wants to merge 4 commits into from
Closed

Conversation

rakeshnitb
Copy link
Contributor

Change-Id: Id658564495af13c35fa78ecde9ab587557aabb47

Change-Id: Id658564495af13c35fa78ecde9ab587557aabb47
Copy link
Contributor

@claincly claincly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rebase to the newest head in main

rakeshnitb and others added 2 commits May 9, 2022 13:20
Change-Id: I7e2d36eb3d69fb09e0d0bbc283d41165c69d4076
@claincly
Copy link
Contributor

claincly commented May 9, 2022

looks good, will start merging process internally

fragmentedSampleSizeBytes = 0;
gotFirstPacketOfVP9Frame = false;
}
previousSequenceNumber = sequenceNumber;
Copy link
Contributor

@claincly claincly May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check if moving this line to out of the if (validateVp9Descriptor(data, sequenceNumber)) works? i.e. move it down one line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By moving "previousSequenceNumber = sequenceNumber;" down, packet(s) with Invalid Payload Descriptor will also get logged in previousSequenceNumber which can lead to directly get follow-on packet without start Code packet.

Change-Id: I92d6d7c539d05b74f83a76fdb8c6691f6c45f48d
icbaker added a commit that referenced this pull request May 24, 2022
@claincly claincly closed this Jun 9, 2022
marcbaechinger pushed a commit that referenced this pull request Jun 14, 2022
@androidx androidx locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants