Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "cmd is unknown" errors on version check #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noppa
Copy link

@noppa noppa commented Nov 11, 2022

The execution continued after version check was made, ending up in "cmd is unknown".

The execution continued after version check was made, ending up in "cmd
is unknown".
@andy-portmen
Copy link
Owner

Can you explain how it helps? How can I reproduce the bug?

@noppa
Copy link
Author

noppa commented Nov 12, 2022

I don't think this "bug" actually causes any issues that'd be visible to the end user. Without the else if, all version check calls to the native client (i.e. when the "check connection status" is clicked) will respond not only with the version, but also with 'cmd is unknown' error message.

I noticed this when debugging why the extension wasn't working for me. This didn't end up being the solution for my issue - that was just a missing piece in configuration. But I figured that even though this extra error message isn't harming anyone at the moment, it probably wasn't intended behaviour either, hence this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants