Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ContextIsolation in Electron 12 #80

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Conversation

andycb
Copy link
Owner

@andycb andycb commented Apr 25, 2021

As we use require in the renderer process, it is necessary to disable context isolation, which now defaults to true in Electron 12: https://www.electronjs.org/docs/breaking-changes

@andycb andycb merged commit 5fef393 into master Apr 25, 2021
@andycb andycb added this to the V1.3 milestone Apr 25, 2021
@andycb andycb deleted the fixAppInElectron12 branch April 25, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant