Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade chai 4.4.1 -> 5.1.2 #234

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Upgrade chai 4.4.1 -> 5.1.2 #234

merged 1 commit into from
Dec 18, 2024

Conversation

andygout
Copy link
Owner

This PR upgrades chai to its current latest version.

This major upgrade was dependent on first migrating this repo to use Node.js-native ECMAScript modules (as done in #222).

Prior to then, the following error message would display:

Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have import {...} from 'chai' or import('chai'). require('chai') will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls.

Mentioned as part of this major release:

  • chai v5.0.0
    • Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have import {...} from 'chai' or import('chai'). require('chai') will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls.

@andygout andygout merged commit 3f8590f into main Dec 18, 2024
1 check passed
@andygout andygout deleted the upgrade-chai branch December 18, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant