Support more options for rebasing changes #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukegb
added a commit
to lukegb/gerrit-queue
that referenced
this pull request
Oct 20, 2023
We want to use the new Gerrit `on_behalf_of_uploader` feature introduced in Gerrit 3.8, but the go-gerrit maintainer isn't particularly active. In the interim, switch to using lukegb's rebaseinput branch. See andygrunwald/go-gerrit#155. In the interim, switch to
lukegb
added a commit
to lukegb/gerrit-queue
that referenced
this pull request
Oct 20, 2023
We want to use the new Gerrit `on_behalf_of_uploader` feature introduced in Gerrit 3.8, but the go-gerrit maintainer isn't particularly active. In the interim, switch to using lukegb's rebaseinput branch. See andygrunwald/go-gerrit#155. In the interim, switch to
flokli
pushed a commit
to flokli/gerrit-queue
that referenced
this pull request
Nov 8, 2023
We want to use the new Gerrit `on_behalf_of_uploader` feature introduced in Gerrit 3.8, but the go-gerrit maintainer isn't particularly active. In the interim, switch to using lukegb's rebaseinput branch. See andygrunwald/go-gerrit#155. In the interim, switch to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RebaseInput is relatively big at this point; the main field I'm interested in is actually just
on_behalf_of_uploader, but there are several options missing from go-gerrithttps://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/extensions/api/changes/RebaseInput.java
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#rebase-input