Add support for submit_requirements fields in ChangeInfo. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simony-gke
changed the title
|
@andygrunwald Please review, thanks! |
|
Thanks @simony-gke for the PR. |
|
@andygrunwald friendly ping. We're waiting on this, thanks. |
|
I will take this on the weekend. Sorry for the delay. Life kicked in.
*Andy Grunwald*
Engineering Kiosk <https://engineeringkiosk.dev/> | Aiven
<https://aiven.io/>
Web: andygrunwald.com
Social: Twitter <https://twitter.com/andygrunwald> | GitHub
<https://github.com/andygrunwald> | LinkedIn
<https://www.linkedin.com/in/andy-grunwald-09aa265a/>
Simon Yang ***@***.***> schrieb am Fr. 18. Okt. 2024 um 20:42:
… @andygrunwald <https://github.com/andygrunwald> friendly ping. We're
waiting on this, thanks.
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACOEQDZMVQPKKDEA3HR7DTZ4FI73AVCNFSM6AAAAABPZKYTD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGAZTQNZUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
andygrunwald
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Gerrit had deprecated label functions and migrate to submit-requirements (https://gerrit-review.googlesource.com/Documentation/config-labels.html), our project (Prow, https://docs.prow.k8s.io/docs/overview/) needs to get this submit-requirements info associated with a change.