Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Custom Labels #29

Merged
merged 2 commits into from
Nov 15, 2016
Merged

Support Custom Labels #29

merged 2 commits into from
Nov 15, 2016

Conversation

opalmer
Copy link
Contributor

@opalmer opalmer commented Nov 9, 2016

This is a small but breaking change to support labels other than Code-Review and Verified.

See #21 for a full discussion.

@opalmer opalmer added this to the 0.2.0 milestone Nov 9, 2016
@opalmer opalmer self-assigned this Nov 9, 2016
@codecov-io
Copy link

codecov-io commented Nov 9, 2016

Current coverage is 17.32% (diff: 100%)

Merging #29 into master will not change coverage

@@             master        #29   diff @@
==========================================
  Files            20         20          
  Lines          1709       1709          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            296        296          
  Misses         1386       1386          
  Partials         27         27          

Powered by Codecov. Last update bb51cd9...cefbfcb

@opalmer
Copy link
Contributor Author

opalmer commented Nov 9, 2016

@andygrunwald / @andygrunwald, please have a look. I'm going to switch one of my projects over to this branch to continue testing but so far this seems to work like we discussed.

@andygrunwald
Copy link
Owner

@opalmer Looks like a small and easy change. Go ahead when you are done with your testing.

@opalmer
Copy link
Contributor Author

opalmer commented Nov 15, 2016

Have not had any issues with this since I created the PR, merging.

@opalmer opalmer merged commit a5c14a9 into master Nov 15, 2016
@opalmer opalmer deleted the fix_labels branch January 21, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants