Fix ChangeFileContentInChangeEdit #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some problems I had when trying to update file contents in changes on chromium-review.googlesource.com. Not crazy about adding a separate NewRawPutRequest func, but it didn't seem to fit in well with NewRequest().
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 17.32% 17.59% +0.27%
==========================================
Files 20 20
Lines 1709 1722 +13
==========================================
+ Hits 296 303 +7
- Misses 1386 1389 +3
- Partials 27 30 +3
Continue to review full report at Codecov.
|
|
<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix for making changes on chromium-review.googlesource.com.
This allows the caller to pass the new file contents as a string.