Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Follow the Go Release Policy #85

Merged
merged 2 commits into from
Dec 31, 2020
Merged

README: Follow the Go Release Policy #85

merged 2 commits into from
Dec 31, 2020

Conversation

andygrunwald
Copy link
Owner

No description provided.

Copy link
Collaborator

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM. Thanks!

README.md Outdated
@@ -23,7 +23,8 @@ go-gerrit is a [Go](https://golang.org/) client library for accessing the [Gerri

## Installation

go-gerrit requires Go version 1.10 or greater.
go-gerrit follows the [Go Release Policy](https://golang.org/doc/devel/release.html#policy).
This means, we support the current + two previous Go version releases.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace “current + two previous” with “current + previous”. Go supports two major releases at a time, not three.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Misread the policy. Thanks @dmitshur!

Go supports two major releases at a time, not three.
@andygrunwald andygrunwald merged commit 46815e4 into master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants