Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize CI runs #35

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Optimize CI runs #35

merged 4 commits into from
Oct 17, 2022

Conversation

andygrunwald
Copy link
Owner

A few small optimizations like:

  • Run go fmt only on the last Go version
  • Run go vet only on the last Go version
  • Run staticcheck only on the last Go version
  • Run unit tests against Go v1.19-v1.15

@andygrunwald
ci: run go fmt only on latest Go version
c963bc2 
There is no need to run it for every supported Go version.
@andygrunwald
ci: run go vet only on latest Go version
380e427 
There is no need to run it for every supported Go version.
@andygrunwald
ci: run staticcheck only on latest Go version
9b547f3 
There is no need to run it for every supported Go version.
@andygrunwald
ci: run unit tests on Go 1.19-1.15
eac6ee7 
Officially, we only support the last two Go versions (1.19 / 1.18).
However, our Go modules files says, we are OK to run on v1.15.
As long as the unit tests passes on those versions, I don't see
a need to raise the minimum version requirement.

Testing against these versions doesn't hurt, as long as it won't
require much effort.
@andygrunwald andygrunwald merged commit 9b4052c into master Oct 17, 2022
@andygrunwald andygrunwald deleted the optimize-ci-runs branch October 17, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andygrunwald