Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added less block #114

Closed
wants to merge 1 commit into from
Closed

Conversation

viktor-nikolaev
Copy link

Added less block.
@kirill-konshin please test the block since I can't do it for a while.

@kirill-konshin
Copy link
Contributor

Most importantly, the plugin does not work with Extract Text block, the output is just a string in JS bundle, SASS block does not work with it as well: #115.

Second, adding sourceMap: true to options produces error:

ERROR in ./~/css-loader?sourceMap!./~/less-loader?{"sourceMap":true}!./src/styles.less
Module build failed: TypeError: Path must be a string. Received undefined

@kirill-konshin
Copy link
Contributor

kirill-konshin commented Feb 15, 2017

Regarding the issue with extractText (#115) - documentation needs to be fixed.
Source map error also happens in SASS block too: #116.

@kirill-konshin
Copy link
Contributor

This can be merged now since #116 has been fixed with #119.

@andywer
Copy link
Owner

andywer commented Mar 1, 2017

Can you please check which linting issues make the build fail?

I will have a look at it myself, but right now I am busy working on the new API (#125).

@sapegin
Copy link
Collaborator

sapegin commented Aug 9, 2017

@andywer Do we want this in the core? I’d suggest to keep it as a third-party block since Less is way less popular that Sass.

@andywer
Copy link
Owner

andywer commented Aug 9, 2017

Since nobody complained recently... I suppose it would make more sense to keep it as a 3rd-party block.
@kirill-konshin Are you interested in publishing it as your own repo/package?

@kirill-konshin
Copy link
Contributor

I don't mind, just tell me how should I take over it.

P.S. I personally think that official support of Less is also a very nice to have thing along with official support of Sass. I use both actually, in different projects, because of different advantages.

@andywer
Copy link
Owner

andywer commented Aug 12, 2017

Sure and I would appreciate it a lot if you would find some time to publish a less block under your own flag, nevertheless. It is still important and I will tweet about it.

We will advertise your block here, too, don't worry. I know I keep saying this for far too long, but we shall have an official list of 3rd-party blocks in a prominent place soon :)

@sapegin
Copy link
Collaborator

sapegin commented Aug 12, 2017

I could find around 6 third-party blocks on npm, so Readme could be a good place to start — I can send a PR.

@andywer
Copy link
Owner

andywer commented Aug 12, 2017

Sure, let's just put it into the readme for now!

@sapegin
Copy link
Collaborator

sapegin commented Sep 18, 2017

@kirill-konshin Are you still interested in making a third-party block for Less?

@kirill-konshin
Copy link
Contributor

Yes. I will publish it today/tomorrow. What's the naming convention?

@sapegin
Copy link
Collaborator

sapegin commented Sep 18, 2017

@kirill-konshin
Copy link
Contributor

https://www.npmjs.com/package/webpack-blocks-less published almost as is based on this PR. Contributions are welcome. This PR can be closed, but please, add a reference to README then...

@sapegin
Copy link
Collaborator

sapegin commented Sep 21, 2017

@kirill-konshin Awesome! You need to update an example in readme and repository field in package.json — they still point to webpack-blocks repo.

And feel free to send a PR to add a link to our Readme ;-)

@sapegin sapegin mentioned this pull request Oct 8, 2017
@andywer andywer closed this in #229 Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants