(Ground Storage) Apply smoke particles to some items #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crucible, cooking pot and meal containers don't have particles when placed. These changes fixes anegostudios/VintageStory-Issues#1577
Make BlockSmeltedContainer.GetContents public
Craluminum2413
changed the title
|
Could you fix this so there aren't merge conflicts? |
|
No idea how to fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes anegostudios/VintageStory-Issues#1577
Crucible, cooking pot and meal containers don't have particles when placed, this code adds those particles.
I tested all particle positions, they are aligned with MeshAngle.
I couldn't use tfMatrices because it is a mess when rotated, -8.xxxx, -4.xxx etc. are unreadable values so it is much easier to do it manually.
Top position is set from MaxY field from first collision box, so you might need to lower collision box in GroundStorable behavior for some items or add OverrideMaxYParticlePos to GroundStorageProperties and then apply it in OnAsyncClientParticleTick method.