Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Charcoal Pit Detection #76

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pizza2004
Copy link

@pizza2004 pizza2004 commented Oct 3, 2024

The old code would check ± 6 in each direction, which meant that it was actually checking a 13x13x13 cube with the fire pit at the center. I have slightly modified it so it will check an 11x11x11 cube located under the fire pit, with the fire pit in the center. This should match the handbook saying that “your charcoal pit can be any dimension up to 11x11x11 blocks” and “Cover the filled pit completely, but leave the top of a single stack of firewood in the center exposed to air.”

It might be desireable to make it so it doesn’t have to be centered in the cube horizontally, but that would take a more complex fix, while this should make it match the explanation from the handbook.

@pizza2004
Copy link
Author

I have updated it slightly so that it is possible to set the MaxPileSize publicly now, allowing modding to change how big you can make charcoal pits more easily.

@pizza2004
Copy link
Author

I have now edited it so that it will check for any configuration of firewood with a firepit sitting on top of a stack that fits inside of a maxSize range cube in all 3 directions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant