Fix Doors and Trapdoors HeatRetention and LiquidBarrier Properly Track Solid Side #79
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized at some point that if you place a door down in what would be the open position and then “close” it the game will think of it as open and it will count as open for cases like cellar and liquid flowing through it. This PR changes the logic slightly so that instead of appearing to be a completely solid block any time the Opened variable is false and a non-solid block otherwise, the game will respond to it as if the side of the door that is up against the wall of the space is the solid side, like how it treats slabs.