Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and minor changes #1

Merged
merged 4 commits into from
May 13, 2020
Merged

Conversation

sphinks
Copy link
Contributor

@sphinks sphinks commented May 13, 2020

I try to use this tap to get data from bigquery, but have to fix several issues, so doing backmerge PR.

  1. Fix readme.
  2. Add output of state message to be compatible with any target.
  3. Fix lost require lib in setup script.

@daigotanaka daigotanaka merged commit 6474a9c into anelendata:master May 13, 2020
@daigotanaka
Copy link
Collaborator

@sphinks Thanks for improving the code and docs! Looking good.

@daigotanaka
Copy link
Collaborator

@sphinks Can you review this (breaking change v0.3.0)
#3
I also wanted to discuss the release on PyPi since you did that with the previous version. Thx!

@sphinks
Copy link
Contributor Author

sphinks commented Aug 20, 2020

@daigotanaka I'm not really good with Python, but I do not notice any issues. Also, I'm not sure I can be mentioned as author yet (just fix couple issues:)), I suppose contributor is much closer to the truth :)

Do you want me to release it on PyPi? Or, I can delete my release on PyPi in case you want to release it by youself.

@daigotanaka
Copy link
Collaborator

@sphinks got it about contributor. Can you add me (daigotanaka) as a collaborator at https://pypi.org/manage/project/tap-bigquery/collaboration so I don't have to contact you every time I need to release? Thx!

@sphinks
Copy link
Contributor Author

sphinks commented Aug 21, 2020

@daigotanaka done, you can use it.

@daigotanaka
Copy link
Collaborator

Thx @sphinks ! ...also letting you know that I'm changing the repo name to tap-bigquery from tap_bigquery to be consistent with the pypi release name.

@sphinks
Copy link
Contributor Author

sphinks commented Aug 23, 2020

It is make sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants