ci: update workflows #94
Conversation
| format-csharp: | ||
| needs: format-protobuf |
There was a problem hiding this comment.
This one takes so much time that I prefer having failed rather than waiting for it
There was a problem hiding this comment.
Need to be changed
| echo "version=$VERSION" >> $GITHUB_ENV | ||
|
|
||
| - name: Get version from tag | ||
| if: ${{ contains(github.ref, 'refs/tags') }} |
There was a problem hiding this comment.
How do you ensure that the tag is coherent ?
This should work only on X.Y.Z tags. Moreover, how do you ensure that the tag given is really the next tag ?
Things I do not want to see:
0.6.6 -> 0.8.0
0.6.6 -> 0.6.8
There was a problem hiding this comment.
I can't. Maintainers are responsible for publishing the correct tag (and you can do this using a PR with a review). Using an automated system is the same, you have the responsibility to add feature or breaking in a comment from one or more commit. So, if another maintainer forgot to add breaking in the commit message, the tag will not be correct and the workflow can be achieved by only one person. With a tag release from a PR, you must have a pair validation which I think is better.
There was a problem hiding this comment.
I understand that we cannot check if the dev missed a breaking or a feature but we can still filter for tags that match X.Y.Z.
|
As I do not understand completely how to contribute and make a release, maybe it is time to fill in the HOW-TO-CONTRINUTE ? And put a section on how to release ? |
esoubiran-aneo
added
wontfix
This will allow CI to fail faster if an error occured and rename some part to improve readibility
fix #93