Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Retrieve README #1083

Closed
wants to merge 1 commit into from
Closed

docs: Retrieve README #1083

wants to merge 1 commit into from

Conversation

lzianekhodja-aneo
Copy link
Contributor

No description provided.

@lzianekhodja-aneo lzianekhodja-aneo added the Documentation Improvements or additions to documentation label May 16, 2023
@lzianekhodja-aneo lzianekhodja-aneo self-assigned this May 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@lemaitre-aneo lemaitre-aneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc should not be recreated here, and most of it already exist: https://aneoconsulting.github.io/ArmoniK/installation

The best way forward is to change links in the README to this doc, and fill the gap in https://github.com/aneoconsulting/ArmoniK/tree/main/.docs/content

@lzianekhodja-aneo
Copy link
Contributor Author

We need to fill in the gaps and have the new documentation ready before deleting the old documentation.
There are still READMEs that point to enixisting files and new users are still getting the 404 error and the site is still not as convenient.


In this project, we present the different steps to deploy ArmoniK scheduler in different environments.

# Quick install of ArmoniK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce fichier a effectivement été supprimé mais je pense qu'il faut y mettre plus d'explication (ou plus d'explication sur ArmoniK) parce qu'en l'état, il n'est pas utilisable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce fichier n'est à mon avis pas utile.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mis à jour dans la documentation (avec une version pour systemd qui simplifie grandement l'installation).

https://aneoconsulting.github.io/ArmoniK/installation/windows/wsl2-with-systemd
https://aneoconsulting.github.io/ArmoniK/installation/windows/wsl2-with-genie

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzianekhodja-aneo
Copy link
Contributor Author

Let's finalize the documentation first, while updating the existing.
If we want to remove these files, we must first update the READMEs that point to links that return 404 errors.

@esoubiran-aneo
Copy link
Contributor

We need to fill in the gaps and have the new documentation ready before deleting the old documentation. There are still READMEs that point to enixisting files and new users are still getting the 404 error and the site is still not as convenient.

Je suis désolé mais je ne vois pas où se trouve la documentation actuelle. Les quelques README éparpillés dans le repo ne sont pas maintenable pour nous mais surtout sont très difficile à utiliser par la suite rendant complexe l'intégration de nouveaux contributeurs.

Il est vrai que la nouvelle documentation (en ligne) n'est pas complète mais jusqu'à preuve du contraire, pas grand monde participe à sa création. Il se trouve que Rome ne s'est pas fait en 1 jour et il en sera de même pour celle d'ArmoniK évidemment. Mais si on ne commence jamais à s'y mettre, on n'y arrivera effectivement jamais.

Pour information, des issues ont été ouvertes et assignés à des membres de l'équipe mais jamais complétées.

#1004
#1035
#1034
#1025
#991
#965
aneoconsulting/ArmoniK.Core#252
aneoconsulting/ArmoniK.Core#254
aneoconsulting/ArmoniK.Core#253
aneoconsulting/ArmoniK.Core#337
aneoconsulting/ArmoniK.Core#209
aneoconsulting/ArmoniK.Community#7
aneoconsulting/ArmoniK.Community#6
aneoconsulting/ArmoniK.Community#5
aneoconsulting/ArmoniK.Community#4

En ce qui concerne les README qui ont des liens vers nulle part, il ne faut pas hésiter à faire des pull requests pour les changer et les mettre à jour !

the site is still not as convenient

Sur ce point, je serai ravi d'avoir des retours. https://github.com/aneoconsulting/ArmoniK-docs-theme

@lzianekhodja-aneo
Copy link
Contributor Author

Je ne dis pas le contraire. Je suis complètement d'accord, la documentation n'est pas encore complète et celle d'avant faut la mettre à jour. Nous devons le faire au fur et à mesure.
Je signale seuelement qu'avant de supprimer des fichiers qui généreront des erreurs 404, il faut d'abord tout déplacer et supprimer les README qui pointent vers des liens inexistants ou remplacer ces liens vers la nouvelle documentation.

@lemaitre-aneo
Copy link
Contributor

Please check out #1084 that revive the missing doc in the actual documentation folder, and fixes dead links.

@lzianekhodja-aneo lzianekhodja-aneo deleted the LZK/retrieve-readme branch May 23, 2023 05:44
@lzianekhodja-aneo lzianekhodja-aneo removed their assignment May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants