Inertia-2: remove unneeded hand calcs that don't render #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@Joosty just seeing this. Should I close the other one or are they different changes? |
|
@angadhn the two open PR's are different changes - I have closed the rogue one. |
|
@Joosty please update both branches. I added an Action to check syncs when PRs are opened. That was not part of this text. Sorry! |
|
@angadhn have updated both branches, hope this is okay :) |
|
@Joosty sorry. You might need to do this once more on both branches. :( |
|
@angadhn I don't seem to be able to. See below the sync option for both branches.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second attempt at inertia-2, I originally messed up and lumped the inertia 1 and 2 changes into one PR but this has now been closed and fixed into two separate PR's for inertia 1 & 2
All this PR does is remove unneeded hand calcs as they have been transcribed prior - in the current state they also don't render which makes the book look messy.
see image below
