Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /unsolved_problems/PS1/PS1.html #27

Closed
adrulpz opened this issue Sep 16, 2024 · 5 comments
Closed

Issue on page /unsolved_problems/PS1/PS1.html #27

adrulpz opened this issue Sep 16, 2024 · 5 comments

Comments

@adrulpz
Copy link
Contributor

adrulpz commented Sep 16, 2024

Hi Angadh, just a couple of observations on this set.

Q1: N and E could be in bold letters. The last two expressions still have the "$" symbol and is missing a space just before "and".
Q2: same problem, v still have the "$" symbol
Q3: same problem with the acceleration expression
Q4: after "given by: "needs to be rewritten, there are no spaces, and it is all as a math expression

@angadhn
Copy link
Owner

angadhn commented Sep 17, 2024

great. How about making the changes? Top-level procedure and I think @Joosty can guide too):

  1. fork the repo.
  2. clone your fork.
  3. create a branch called "PS1_Fix".
  4. Make changes.
  5. Commit and push changes to fork.
  6. Open a PR.

Procedures are outlined in greater detail here: https://github.com/angadhn/SpacecraftDynamics/blob/main/CONTRIBUTING.md

@Joosty
Copy link
Collaborator

Joosty commented Sep 17, 2024

Happy to help if you need to be ran through anything @adrulpz :) can hop on a call if you need!

@adrulpz
Copy link
Contributor Author

adrulpz commented Sep 17, 2024

Thanks, @Joosty. I appreciated it. I will make the changes later today. If I need help I will reach out :)
And @angadhn, I think you forgot the link 😅

@angadhn
Copy link
Owner

angadhn commented Sep 17, 2024

@adrulpz comment updated ;)

@angadhn
Copy link
Owner

angadhn commented Sep 30, 2024

Fixed in PR29.

@angadhn angadhn closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants