Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS1 Fix #29

Merged
merged 7 commits into from
Sep 30, 2024
Merged

PS1 Fix #29

merged 7 commits into from
Sep 30, 2024

Conversation

adrulpz
Copy link
Contributor

@adrulpz adrulpz commented Sep 17, 2024

Hi, the problem is apparently just with the equation using $$ for a block... so I added more cells XD, and that should be fine just for better-looking equations with actual space between them.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@angadhn
Copy link
Owner

angadhn commented Sep 26, 2024

@adrulpz you do not actually have the most up to date version of my main. You can see that both your main and PS1_Fix; for example, your PS1_Fix branch is 154 commits behind my main.
image

In fact, even your main is behind mine baby the same number. So you need to first update your main and then your PS1_Fix. push changes from both to GitHub. This is the process. The specifics on how to do all this at the command line? Glad you asked! This can be found here.

Maybe @Joosty can help here too, if/when he has time- pretty please.

@angadhn angadhn requested a review from Joosty September 26, 2024 11:44
@Joosty
Copy link
Collaborator

Joosty commented Sep 26, 2024

Happy to help. @adrulpz I would suggest just clicking this sync button in the GitHub website shown in my screenshot below.

image

If this doesn't work then please let me know and we can try the command line route...

Cheers

@adrulpz
Copy link
Contributor Author

adrulpz commented Sep 26, 2024

I thought I had pushed that button, but maybe I just didn't and didn't check later. Thanks! I'll let you know

@adrulpz
Copy link
Contributor Author

adrulpz commented Sep 27, 2024

So... I think what happened is that I synchronised the changes with the button in the main branch after creating the fix branch because I aborted the merging on the terminal 😅. Anyway, I believe everything has been updated. If not, would it be better if I started over again, creating another branch?

Joosty
Joosty previously requested changes Sep 28, 2024
Copy link
Collaborator

@Joosty Joosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes to the PS1.ipynb file, the equations and formatting errors look much better.

I am a bit confused as to why there are a few additional files now (namely vector.ipynb in lecture 101 and PS1-checkpoint.ipynb in .ipynb-checkpoints) . These are circled in the image below. Are these meant to be here or is this an impact of the weird sync stuff?

cheers

image

@angadhn
Copy link
Owner

angadhn commented Sep 28, 2024

@Joosty I believe this 101 file is from the tutorial.

@adrulpz can you please delete that and the entire directory .ipynb_checkpoints please? Then commit and push.

@adrulpz
Copy link
Contributor Author

adrulpz commented Sep 30, 2024

Done :)
thanks for reviewing it and for the guidance @Joosty

@angadhn angadhn dismissed Joosty’s stale review September 30, 2024 11:50

fixed without needing another review.

@angadhn angadhn merged commit 38b4000 into angadhn:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants