-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PS1 Fix #29
PS1 Fix #29
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@adrulpz you do not actually have the most up to date version of my In fact, even your Maybe @Joosty can help here too, if/when he has time- pretty please. |
Happy to help. @adrulpz I would suggest just clicking this sync button in the GitHub website shown in my screenshot below. If this doesn't work then please let me know and we can try the command line route... Cheers |
I thought I had pushed that button, but maybe I just didn't and didn't check later. Thanks! I'll let you know |
So... I think what happened is that I synchronised the changes with the button in the main branch after creating the fix branch because I aborted the merging on the terminal 😅. Anyway, I believe everything has been updated. If not, would it be better if I started over again, creating another branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes to the PS1.ipynb file, the equations and formatting errors look much better.
I am a bit confused as to why there are a few additional files now (namely vector.ipynb in lecture 101 and PS1-checkpoint.ipynb in .ipynb-checkpoints) . These are circled in the image below. Are these meant to be here or is this an impact of the weird sync stuff?
cheers
Done :) |
fixed without needing another review.
Hi, the problem is apparently just with the equation using $$ for a block... so I added more cells XD, and that should be fine just for better-looking equations with actual space between them.