Adding TheRealLecture1 file #14

Hardit-Saini · 2024-08-30T22:06:10Z

Lecture 1 uploaded. Called it TheRealLecture1 as there was already a file called lecture1.

review-notebook-app · 2024-08-30T22:06:15Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

angadhn · 2024-08-30T23:47:08Z

@Emma-airi and @mitanshc can you both help review this please?

mitanshc · 2024-08-31T09:01:59Z

orbital-mechanics/TheRealLecture1/SpacecraftDynamicsWeek1r;$.ipynb

@@ -0,0 +1,428 @@
+{


Good, but minor formatting issues to bring it in line with other lectures
Remove “Lecture 1” heading
All vectors are denoted by a bold face. This can be done using ‘\mathbf{}’. This is applied throughout the lecture.

Reply via ReviewNB

# Vectors (Brief Recap)
Following with what Mitansh has mentioned, you can make this as the main title of the chapter. It is good as a first level heading.
This heading will also need to have its own markdown cell.
Lastly, you would need to add the list of authors below the title, for example:

# Vectors (Brief Recap) Prepared by: [insert full name here](https://github.com/insert your username here) and [Angadh Nanjangud](https://www.angadhn.com/)

mitanshc · 2024-08-31T09:01:59Z

orbital-mechanics/TheRealLecture1/SpacecraftDynamicsWeek1r;$.ipynb

@@ -0,0 +1,428 @@
+{


Not sure why, but there seems to be an extra “/“ in front of every equation. Maybe this is how it was typed out? Or maybe just me?

Reply via ReviewNB

More information on the equations throughout the notebook:
Write the equations on each line (not a new cell, just leave some space between the equations and other texts.) For example:

### Two-Body Relative Dynamics #### Newton's Second Law 1. $ m_2 \ddot{\vec{r}}_2 = \vec{F}_{21} = - \frac{G m_1 m_2 \vec{r}}{r^3} \rightarrow \ddot{\vec{r}}_2 = - \frac{G m_1 \vec{r}}{r^3} $ 2. $ m_1 \ddot{\vec{r}}_1 = \vec{F}_{12} = \frac{G m_1 m_2 \vec{r}}{r^3} \rightarrow \ddot{\vec{r}}_2 = \frac{G m_2 \vec{r}}{r^3} $ Combining these equations:
The equations need to have labels and they also need to be formatted as per this link: https://jupyterbook.org/en/stable/content/math.html#numbering-equations
Follow the formatting style on this link for all the equations you have.

mitanshc · 2024-08-31T09:01:59Z

orbital-mechanics/TheRealLecture1/SpacecraftDynamicsWeek1r;$.ipynb

@@ -0,0 +1,428 @@
+{


For some reason the first equation hasn’t worked. Again probably an extra set of characters somewhere or indentation.

Reply via ReviewNB

mitanshc · 2024-08-31T09:01:59Z

orbital-mechanics/TheRealLecture1/SpacecraftDynamicsWeek1r;$.ipynb

@@ -0,0 +1,428 @@
+{


Same issue with the first equation in this section as well

Reply via ReviewNB

mitanshc · 2024-08-31T09:01:59Z

orbital-mechanics/TheRealLecture1/SpacecraftDynamicsWeek1r;$.ipynb

@@ -0,0 +1,428 @@
+{


Here too.

Hardit, how are you formatting your equations? Is it like Angadh showed in the closed Lecture 7 PR? Because they should all be numbered and you shouldn’t be needing dollar signs (if memory serves right)

Reply via ReviewNB

mitanshc · 2024-08-31T09:01:59Z

orbital-mechanics/TheRealLecture1/SpacecraftDynamicsWeek1r;$.ipynb

@@ -0,0 +1,428 @@
+{


Same issue with equations and I’m not sure if the html will render on the website or not, it certainly isn’t here.

Reply via ReviewNB

Emma-airi · 2024-08-31T12:01:27Z

All the references you have made would need to be sent to the end of the chapter, under its own 2nd level heading.
you can decide on a referencing style for your links as well. I have personally used Harvard referencing style.

Emma-airi · 2024-08-31T12:36:01Z

As part of a table of content section at the beginning of the note, you can do so by:

In this lecture we cover the following topics:
1. [](content:sun-synchronous-orbit)
2. [](content:j2-perturbations)
3. [](content:repeat-groundtrack-orbits)
4. [](content:geosynchronous-orbits)
5. [](content:geostationary-orbits-(GEO))
6. [](content:sunsynchronous-repeat-groundtrack-orbits)
7. [](content:molniya-orbits)
8. [](content:tundra-orbits)
9. [](content:references)

This is how the markdown code looks like for mine.

The content part corresponds to each heading you have used like this for the number 1 content in the list:

(content:sun-synchronous-orbit)=
## Sun Synchronous Orbit

using this format for all the titles will get you up to speed.

You can see how the table of content looks like on the online textbook here: https://www.angadhn.com/SpacecraftDynamics/orbital-mechanics/Lecture12/Lecture12.html#content-sun-synchronous-orbit

angadhn · 2024-09-05T17:08:57Z

@Hardit-Saini do these two things:

can you rename your file to be Lecture1.ipynb
Move this file and the images into the Lecture1 directory

angadhn · 2024-09-05T17:10:32Z

@Hardit-Saini note that you can just drag and drop all the image into the already existing images directory. Otherwise, the older images may get deleted. Thanks!

angadhn · 2024-09-05T17:14:21Z

@Hardit-Saini doesn't look like any of the changes recommended above by @mitanshc and @Emma-airi have been made in the new file. Am I missing something?

Hardit-Saini · 2024-09-05T17:19:13Z

@angadhn @Emma-airi I just commited the new file a few minutes ago, could this please get checked?

angadhn · 2024-09-06T09:40:50Z

@Hardit-Saini also, it looks like this branch is not upto date with my main branch; see image below which says you are 9 commits behind the angadhn/SpacecraftDynamics:main. So you will have to follow the instructions in Contributing.md, just to ensure your fork is updated to have the newest content.

angadhn · 2024-09-06T09:42:52Z

@Hardit-Saini you have not implemented the changes from this comment of mine on this PR. Here is a link to it: #14 (comment)

angadhn · 2024-09-06T09:45:18Z

Please remove the italics for the different notations of vectors.

For example, you can use ${\bf r}$ to get ${\bf r}$. You have done this correctly in the sentence right above Equation 4 but then again the equation has the wrong way of writing $r$. See below for what I mean:

angadhn · 2024-09-06T09:46:52Z

In the below write-up, you have $Q$ as a scalar, which is correct. But the equation itself seems to show a bold-face Q, which is a vector. Please make that also italicised. This is likely happening because you are using brackets incorrectly for \bf which is applying it to every term.

angadhn · 2024-09-06T09:48:08Z

Make $\hat B$ into $\hat {\bf B}$ as it is a vector.

angadhn · 2024-09-06T09:49:16Z

Make unit vectors bold
Figure needs to be inserted correctly as it is currently missing when I generate the online textbook. Please double check this.

angadhn · 2024-09-06T09:51:26Z

Something isn't right here, as well. I believe that $\hat r$ should be in bold in both equations:

@Emma-airi can you also review this entire Lecture once the revisions are made by @Hardit-Saini based on my comments above, please? Thanks!

Hardit-Saini · 2024-09-06T18:12:19Z

@Hardit-Saini do these two things:

can you rename your file to be Lecture1.ipynb

Move this file and the images into the Lecture1 directory

Hello @angadhn , I dont understand what I am meant to do here. My file name is Lecture1 however my branch is called TheRealLecture1 (this is because theres already a branch called Lecture1 with content in it so I didnt want to intrude). Could this please be elaborated?

@Emma-airi
@thedukeofeelam

angadhn · 2024-09-06T18:16:39Z

@Hardit-Saini no worries. Just make the changes suggested by @thedukeofeelam. And ensure that you've updated your fork before pushing your next commit.

Emma-airi · 2024-09-06T19:26:24Z

In the below write-up, you have
Q
as a scalar, which is correct. But the equation itself seems to show a bold-face Q, which is a vector. Please make that also italicised. This is likely happening because you are using brackets incorrectly for \bf which is applying it to every term.

Good Evening,

I wanted to ask if the unit vectors should be in boldface as well, or is the hat just enough. For example:
\hat{bf{i}}
or
\hat{rm{i}
or
\hat{bm{i} (this makes i hat, italics)

angadhn · 2024-09-06T19:56:23Z

It should be consistent with the later notes- boldface minimum but I imagine we have the hats too. Just take a look at the textbook link that is live.

… updated either because I was getting error messages earlier, pls let me know

Hardit-Saini · 2024-09-07T13:19:53Z

I worded the commit message very poorly, I meant the file was updated thanks to @Emma-airi however I encountered some issues during fork updating (all thanks to my own incompetency).

angadhn · 2024-09-08T08:39:40Z

@Emma-airi can you review this tomorrow and let me know if ready for merge?

Emma-airi · 2024-09-08T15:33:32Z

Either bullet points or a comma between the gravitational constant and unit vector r parameters, makes it neater.

With the two images below, it seems to be a duplicate, but I assume they were meant to be mini titles, so I would recommend meaning them bold by using the double ** on each end of the titles; or using bullet points + removing the double title.

Emma-airi · 2024-09-08T15:35:00Z

I apologise for not spotting these on the files when we were first preparing them @Hardit-Saini. Other than these, I am more than happy for the file to be merged!

Emma-airi · 2024-09-08T15:39:40Z

@Emma-airi can you review this tomorrow and let me know if ready for merge?

Good afternoon @angadhn , I wanted to confirm if there is anything else you expected me to do concerning the merge apart from looking through the document. I am wondering if there is a tool I should have access to that allows me to view if the file is ready to be merged and I am not using it.

angadhn · 2024-09-08T15:50:31Z

@Emma-airi all good. Just reviews for now. Only I should do merging. It's kind of a new thing for me too so only I should be the point of failure there until I learn better :-)

thanks for the effort reviewing on a Sunday!

angadhn · 2024-09-09T12:26:51Z

@Hardit-Saini, have you addressed the comments by @Emma-airi ?

angadhn · 2024-09-09T12:31:37Z

@Hardit-Saini you will also need to make sure to update this again as I merged your other PR. You can see the fruits of your labour are now online: https://www.angadhn.com/SpacecraftDynamics/orbital-mechanics/Lecture10/Lecture10.html

Hardit-Saini · 2024-09-09T12:42:54Z

@angadhn Sorry, I would like to check if I uploaded the right version of the file. Please give me a moment

Hardit-Saini · 2024-09-09T12:48:01Z

Ok I just checked reviewNB and the most recent commit is the correct file and has the changes @Emma-airi requested. It can be merged now @angadhn and thank you.

angadhn · 2024-09-09T12:51:32Z

@Hardit-Saini Legend! Thanks again for all the work y'all. Celebration gathering sometime next week. @Emma-airi @mitanshc @Joosty @thedukeofeelam @nozzington @calan04

Adding TheRealLecture1 file

a81b2c1

mitanshc reviewed Aug 31, 2024

View reviewed changes

Hardit-Saini added 2 commits September 5, 2024 17:45

updating the main, ignore

b19242a

Merging main - Please ignore

65a060d

Hardit-Saini requested a review from angadhn as a code owner September 5, 2024 16:51

Lecture 1 ready for final review

ddb2dca

Updated file - Thanks to Mr Airiofolo, Im not confident this is fully…

9447f5d

… updated either because I was getting error messages earlier, pls let me know

angadhn requested a review from Emma-airi September 8, 2024 08:39

Merge branch 'angadhn:main' into TheRealLecture1

73b8d82

Should be it

edd576e

This should be the updated file.

3c4e5d9

angadhn approved these changes Sep 9, 2024

View reviewed changes

angadhn merged commit b050034 into angadhn:main Sep 9, 2024
1 check passed

Adding TheRealLecture1 file #14

Adding TheRealLecture1 file #14

Conversation

Hardit-Saini commented Aug 30, 2024

review-notebook-app bot commented Aug 30, 2024

angadhn commented Aug 30, 2024

mitanshc Aug 31, 2024 • edited Loading

Choose a reason for hiding this comment

Emma-airi Aug 31, 2024

Choose a reason for hiding this comment

mitanshc Aug 31, 2024 • edited Loading

Choose a reason for hiding this comment

Emma-airi Aug 31, 2024

Choose a reason for hiding this comment

mitanshc Aug 31, 2024 • edited Loading

Choose a reason for hiding this comment

mitanshc Aug 31, 2024 • edited Loading

Choose a reason for hiding this comment

mitanshc Aug 31, 2024 • edited Loading

Choose a reason for hiding this comment

mitanshc Aug 31, 2024 • edited Loading

Choose a reason for hiding this comment

Emma-airi commented Aug 31, 2024

Emma-airi commented Aug 31, 2024

angadhn commented Sep 5, 2024

angadhn commented Sep 5, 2024

angadhn commented Sep 5, 2024

Hardit-Saini commented Sep 5, 2024

angadhn commented Sep 6, 2024

angadhn commented Sep 6, 2024

angadhn commented Sep 6, 2024 • edited by Emma-airi Loading

angadhn commented Sep 6, 2024 • edited by Emma-airi Loading

angadhn commented Sep 6, 2024 • edited by Emma-airi Loading

angadhn commented Sep 6, 2024 • edited by Emma-airi Loading

angadhn commented Sep 6, 2024 • edited by Emma-airi Loading

Hardit-Saini commented Sep 6, 2024

angadhn commented Sep 6, 2024

Emma-airi commented Sep 6, 2024 • edited Loading

angadhn commented Sep 6, 2024

Hardit-Saini commented Sep 7, 2024 • edited Loading

angadhn commented Sep 8, 2024

Emma-airi commented Sep 8, 2024 • edited Loading

Emma-airi commented Sep 8, 2024

Emma-airi commented Sep 8, 2024

angadhn commented Sep 8, 2024

angadhn commented Sep 9, 2024

angadhn commented Sep 9, 2024

Hardit-Saini commented Sep 9, 2024

Hardit-Saini commented Sep 9, 2024

angadhn commented Sep 9, 2024

mitanshc Aug 31, 2024 •

edited

Loading

mitanshc Aug 31, 2024 •

edited

Loading

mitanshc Aug 31, 2024 •

edited

Loading

mitanshc Aug 31, 2024 •

edited

Loading

mitanshc Aug 31, 2024 •

edited

Loading

mitanshc Aug 31, 2024 •

edited

Loading

angadhn commented Sep 6, 2024 •

edited by Emma-airi

Loading

angadhn commented Sep 6, 2024 •

edited by Emma-airi

Loading

angadhn commented Sep 6, 2024 •

edited by Emma-airi

Loading

angadhn commented Sep 6, 2024 •

edited by Emma-airi

Loading

angadhn commented Sep 6, 2024 •

edited by Emma-airi

Loading

Emma-airi commented Sep 6, 2024 •

edited

Loading

Hardit-Saini commented Sep 7, 2024 •

edited

Loading

Emma-airi commented Sep 8, 2024 •

edited

Loading