-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TheRealLecture1 file #14
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@Emma-airi and @mitanshc can you both help review this please? |
@@ -0,0 +1,428 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, but minor formatting issues to bring it in line with other lectures
- Remove “Lecture 1” heading
- All vectors are denoted by a bold face. This can be done using ‘\mathbf{}’. This is applied throughout the lecture.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Vectors (Brief Recap)
- Following with what Mitansh has mentioned, you can make this as the main title of the chapter. It is good as a first level heading.
- This heading will also need to have its own markdown cell.
- Lastly, you would need to add the list of authors below the title, for example:
# Vectors (Brief Recap) Prepared by: [insert full name here](https://github.com/insert your username here) and [Angadh Nanjangud](https://www.angadhn.com/)
@@ -0,0 +1,428 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why, but there seems to be an extra “/“ in front of every equation. Maybe this is how it was typed out? Or maybe just me?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More information on the equations throughout the notebook:
- Write the equations on each line (not a new cell, just leave some space between the equations and other texts.) For example:
### Two-Body Relative Dynamics #### Newton's Second Law 1. $ m_2 \ddot{\vec{r}}_2 = \vec{F}_{21} = - \frac{G m_1 m_2 \vec{r}}{r^3} \rightarrow \ddot{\vec{r}}_2 = - \frac{G m_1 \vec{r}}{r^3} $ 2. $ m_1 \ddot{\vec{r}}_1 = \vec{F}_{12} = \frac{G m_1 m_2 \vec{r}}{r^3} \rightarrow \ddot{\vec{r}}_2 = \frac{G m_2 \vec{r}}{r^3} $ Combining these equations:
- The equations need to have labels and they also need to be formatted as per this link: https://jupyterbook.org/en/stable/content/math.html#numbering-equations
- Follow the formatting style on this link for all the equations you have.
@@ -0,0 +1,428 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the first equation hasn’t worked. Again probably an extra set of characters somewhere or indentation.
Reply via ReviewNB
@@ -0,0 +1,428 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,428 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too.
Hardit, how are you formatting your equations? Is it like Angadh showed in the closed Lecture 7 PR? Because they should all be numbered and you shouldn’t be needing dollar signs (if memory serves right)
Reply via ReviewNB
@@ -0,0 +1,428 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue with equations and I’m not sure if the html will render on the website or not, it certainly isn’t here.
Reply via ReviewNB
|
As part of a table of content section at the beginning of the note, you can do so by: In this lecture we cover the following topics: 1. [](content:sun-synchronous-orbit) 2. [](content:j2-perturbations) 3. [](content:repeat-groundtrack-orbits) 4. [](content:geosynchronous-orbits) 5. [](content:geostationary-orbits-(GEO)) 6. [](content:sunsynchronous-repeat-groundtrack-orbits) 7. [](content:molniya-orbits) 8. [](content:tundra-orbits) 9. [](content:references) This is how the markdown code looks like for mine.
The content part corresponds to each heading you have used like this for the number 1 content in the list: (content:sun-synchronous-orbit)= ## Sun Synchronous Orbit using this format for all the titles will get you up to speed.
You can see how the table of content looks like on the online textbook here: https://www.angadhn.com/SpacecraftDynamics/orbital-mechanics/Lecture12/Lecture12.html#content-sun-synchronous-orbit
|
@Hardit-Saini do these two things:
|
@Hardit-Saini note that you can just drag and drop all the image into the already existing images directory. Otherwise, the older images may get deleted. Thanks! |
@Hardit-Saini doesn't look like any of the changes recommended above by @mitanshc and @Emma-airi have been made in the new file. Am I missing something? |
@angadhn @Emma-airi I just commited the new file a few minutes ago, could this please get checked? |
@Hardit-Saini also, it looks like this branch is not upto date with my |
@Hardit-Saini you have not implemented the changes from this comment of mine on this PR. Here is a link to it: #14 (comment) |
@Emma-airi can you also review this entire Lecture once the revisions are made by @Hardit-Saini based on my comments above, please? Thanks! |
Hello @angadhn , I dont understand what I am meant to do here. My file name is Lecture1 however my branch is called TheRealLecture1 (this is because theres already a branch called Lecture1 with content in it so I didnt want to intrude). Could this please be elaborated? |
@Hardit-Saini no worries. Just make the changes suggested by @thedukeofeelam. And ensure that you've updated your fork before pushing your next commit. |
Good Evening, I wanted to ask if the unit vectors should be in boldface as well, or is the hat just enough. For example: |
It should be consistent with the later notes- boldface minimum but I imagine we have the hats too. Just take a look at the textbook link that is live. |
… updated either because I was getting error messages earlier, pls let me know
I worded the commit message very poorly, I meant the file was updated thanks to @Emma-airi however I encountered some issues during fork updating (all thanks to my own incompetency). |
@Emma-airi can you review this tomorrow and let me know if ready for merge? |
I apologise for not spotting these on the files when we were first preparing them @Hardit-Saini. Other than these, I am more than happy for the file to be merged! |
Good afternoon @angadhn , I wanted to confirm if there is anything else you expected me to do concerning the merge apart from looking through the document. I am wondering if there is a tool I should have access to that allows me to view if the file is ready to be merged and I am not using it. |
@Emma-airi all good. Just reviews for now. Only I should do merging. It's kind of a new thing for me too so only I should be the point of failure there until I learn better :-) thanks for the effort reviewing on a Sunday! |
@Hardit-Saini, have you addressed the comments by @Emma-airi ? |
@Hardit-Saini you will also need to make sure to update this again as I merged your other PR. You can see the fruits of your labour are now online: https://www.angadhn.com/SpacecraftDynamics/orbital-mechanics/Lecture10/Lecture10.html |
@angadhn Sorry, I would like to check if I uploaded the right version of the file. Please give me a moment |
Ok I just checked reviewNB and the most recent commit is the correct file and has the changes @Emma-airi requested. It can be merged now @angadhn and thank you. |
@Hardit-Saini Legend! Thanks again for all the work y'all. Celebration gathering sometime next week. @Emma-airi @mitanshc @Joosty @thedukeofeelam @nozzington @calan04 |
Lecture 1 uploaded. Called it TheRealLecture1 as there was already a file called lecture1.