Lecture2 branch

[Emma-airi]

Corrections made on Lecture2, ready for final review.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[Joosty]

Just a few things to correct:

• 1. Contents not working: See below an image of the last two contents links not functioning.

• 2. Time is not a vector Time has been made bold as if it were a vector when it is a scalar quantity.

• 3. Rogue $ signs There are cases of rogue dollar signs. This can occur if you accidentally use double dollar signs without leaving a gap so it becomes a linear equation.
  

• 4. Random 1+2
  

• 5. Inconsistent symbols Please go through and check wether each symbol should be bold or non bold and also please ensure consistency in the symbols used. eg here with the 'v'.
  

Hope this helped :)
Joost

[angadhn]

Bloody hell, @Joosty. Beat me to the punch!

[Joosty]

@angadhn I may have missed something so I'm sure there is something left for you to comment on lol

[Joosty]

Okay so after building there are a few issues me or you must've missed last time:

• 1. '/bf' in contents not rendering
  

• 2. '' Symbols appearing around time symbols They are also still bold (they are not vectors and should not be). This appears across the whole text.
  

I will leave more comments (as i have seen a few more issues) in around an hour or two (i have an induction session for ESA at 1).

I would suggest if you have not been, building the book locally to test out the rendering before committing/pushing.

Cheers,
Joost

[Emma-airi]

Okay so after building there are a few issues me or you must've missed last time:

• 1. '/bf' in contents not rendering
  
• 2. '' Symbols appearing around time symbols They are also still bold (they are not vectors and should not be). This appears across the whole text.
  

I will leave more comments (as i have seen a few more issues) in around an hour or two (i have an induction session for ESA at 1).

I would suggest if you have not been, building the book locally to test out the rendering before committing/pushing.

Cheers, Joost

Yes, i have not made time to build the book yet. Ill do it now before i continue with the other files i will be commiting later. Thank you Joost!

[Joosty]

Okay so after building there are a few issues me or you must've missed last time:

• 1. '/bf' in contents not rendering
  
• 2. '' Symbols appearing around time symbols They are also still bold (they are not vectors and should not be). This appears across the whole text.
  

I will leave more comments (as i have seen a few more issues) in around an hour or two (i have an induction session for ESA at 1).
I would suggest if you have not been, building the book locally to test out the rendering before committing/pushing.
Cheers, Joost

Yes, i have not made time to build the book yet. Ill do it now before i continue with the other files i will be commiting later. Thank you Joost!

Will get on with finding any more issues now :)

[Joosty]

@Emma-airi

• 3. Rogue $ signs
  
  
  

• 4. '*' symbol
  

• 5. Bold vs non-bold symbols Across the equations in this file there is an issue with things that are not vectors being highlighted in bold and the same vice versa. See below for some examples - I am skimming here so please check to make sure I am correct on some of these as you have the original notes.
  
  
  
  
  

• 6. Unnecessary/ confusing equation labels
  

I will keep an eye out for anything I missed, any questions please ask :)

[angadhn]

@Joosty the issues you raised look resolved. If you think all looks good, we can merge this. You can do the honours :-)

[Joosty]

Will review and then merge in 30 mins :)

[Joosty]

@Emma-airi @angadhn Looking at it all seems good, the only thing I was unsure about was a few symbols being bold or non-bold which seems to be resolved.

EDIT
I think it needs a GitHub review approved from the code owner @angadhn before I can merge.

[angadhn]

@Emma-airi @angadhn Looking at it all seems good, the only thing I was unsure about was a few symbols being bold or non-bold which seems to be resolved.

EDIT I think it needs a GitHub review approved from the code owner @angadhn before I can merge.

Hmmm. Okay. Thanks!