Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lecture8 branch #20

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Lecture8 branch #20

merged 5 commits into from
Sep 5, 2024

Conversation

Emma-airi
Copy link
Collaborator

Lecture8 Ready for review

@Emma-airi Emma-airi self-assigned this Sep 4, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Joosty Joosty self-assigned this Sep 4, 2024
@Joosty
Copy link
Collaborator

Joosty commented Sep 4, 2024 •
edited by Emma-airi
Loading

Issues for @Emma-airi

  • 1. Contents broken: This should be an easy fix as before.
    image

  • 2. \degree does not work: Please use ^\circ instead.
    image

  • 3. Spelling: Ironic coming from me based on my spelling ability lol
    image

  • 4. Degree thing + Quote box: This would look better all in one quote box. Also \degree.
    image

Not seeing any other surface issues but as usual I may have missed something.

Cheers,
Joost

@Joosty
Copy link
Collaborator

Joosty commented Sep 5, 2024

This looks like solid work @Emma-airi ! I'm happy with this to be merged on my end, following a review from @angadhn of course.

Cheers!

angadhn
angadhn approved these changes Sep 5, 2024
View reviewed changes
Copy link
Owner

@angadhn angadhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent! Merging!

@angadhn angadhn merged commit 6f5d7f6 into angadhn:main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angadhn angadhn angadhn approved these changes

@Joosty Joosty Awaiting requested review from Joosty

Assignees

@Emma-airi Emma-airi

@Joosty Joosty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Emma-airi @Joosty @angadhn