Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove discatsharp from comparison #125

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

Lulalaby
Copy link
Contributor

@Lulalaby Lulalaby commented Sep 22, 2023

Heyo,

I've noticed that my library component, DisCatSharp.Lavalink, has been included in a comparison document since the commit 18f7f67. However, I believe it's important to clarify that DisCatSharp's components are specifically designed to work only with the core library DisCatSharp and are not intended for direct comparison with the libraries listed here. Additionally, Lavalink4NET doesn't appear to be intended to work with DisCatSharp either, which makes this pull request self-explanatory.

To maintain the accuracy and fairness of this comparison, I kindly request the acceptance of the removal of DisCatSharp from the document.

DisCatSharp is not intended to work with other libraries, not is Lavalink4NET intended to work with DisCatSharp
@angelobreuer
Copy link
Owner

angelobreuer commented Sep 22, 2023

Thank you for getting into contact. First, I want to say, the list is just solely made to help a user orientate around the most popular libraries for .NET. I attempted to make it as much unbiased as possible to be fair. I am running an open-source project, not a business, so there is no need for any competition.

The support for DisCatSharp for this library would be extremely easy to implement since L4N was designed to be as adaptable as possible (5-minute work). The reason why there is no out-of-the-box support is that I know DisCatSharp has an in-house component for it, and I only contacted library owners to allow me to provide additional support for v4 for their client where there is no premade library made already to avoid getting into any competition, e.g. if L4N would support DisCatSharp then a user would need to decide between libraries and I did not want to touch the position of DisCatSharp and its Lavalink client component in any possible way.

I do not assume that you thought that I had something bad in my mind when I wrote the comparison, but I just want to mention it explicitly in case it gets delivered like that. I absolutely have no problem with removing it from the comparison list since it is part of user documentation, e.g. providing a help for the user and not something in relation to gain an advantage over possible competition.

@angelobreuer angelobreuer merged commit b4440f3 into angelobreuer:dev Sep 22, 2023
4 checks passed
@angelobreuer
Copy link
Owner

I also pushed the changes instantly to the server the documentation site is running on, however it might need some time to be present on all browsers due to caching

@Lulalaby
Copy link
Contributor Author

Many thanks. I'd like to keep the opportunity open for future to ask for support. At the current time we have no interest tho ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants