If the Latest Version of an Object Is the Same Version as What Will Be Restored Skip It. #5
Conversation
…licates behind command line flag
README.md
Outdated
| @@ -111,6 +112,7 @@ optional arguments: | |||
| --test s3 pit restore testing | |||
| --max-workers MAX_WORKERS | |||
| max number of concurrent download requests | |||
| --avoid-duplicates tries to avoid sopying files that are already at the latest version | |||
s3-pit-restore
Outdated
| @@ -253,6 +270,7 @@ def get_key(obj): | |||
| return obj["Key"] | |||
| return os.path.join(args.dest_prefix, obj["Key"]) | |||
|
|
|||
|
|
|||
|
@kylec32 you should squash all commits into one, not adding others on top. The feature is self contained, touches 2 files, so it should be in a single commit |
|
@angeloc Yeah sorry about that. I didn't plan on squashing until all the rest of the items were accounted for as well (testing and fixing the conflicts that now exist) which will probably not be today just figured I would take care of the easy one off the top. I usually just use Github to do the final sqash and merge myself so its just a different process than I usually follow. I'll squash them all together when I'm finished and request your review. |
|
If you squash the commits on the current branch, then you can do a Thanks again! Your contribution is very appreciated. I don't know if you are looking for a tshirt, but I marked your contribution for hacktober fest (https://hacktoberfest.digitalocean.com/) |
|
Hi! Is anyone working on this right now? I can try to take care of this PR, if you do not have time right now @kylec32. It's sensible to prevent restoring the same files - good catch. |
|
@pjboro I am a bit at a hiatus of working on this right now due to other work priorities. The code works from my testing, we just need to get some tests for it is all we are really waiting for (and of course fix the conficts which shouldn't be too bad). If you are willing to pick up that work then that is great. No toes will be stepped on here. 👍 (I just looked at the date the above message was sent and realize how silly it is to be responding right now, I'm not sure how I missed your message for so long) |
I believe this is targeted to |
Makes an API call to determine if the latest object is the same one as the one that needs to be restored, if so it will skip the copy. This also introduces a new CLI flag --avoid-duplicates that this new funcationality lives behind, if the flag isn't set the old behavior is preserved.
Sorry for the inudation of PRs. Found this tool and it did 97% of what I needed, wanted to help bring it to 100%. I'm sure I'll have to fix some merge conflicts as they are merged in, happy to do that as we go but wanted to make a PR for each individual solution so we can discuss each in isolation.