Skip watcher callbacks for FOVs that already have data generated #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camisowers
reviewed
Jul 25, 2023
srivarra
requested changes
Jul 26, 2023
ngreenwald
requested changes
Jul 26, 2023
ngreenwald
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #346. If the watcher has to be stopped for some reason, currently all the FOVs need to be re-run regardless of whether they were already processed. Fixes this so the watcher skips these FOVs instead.
How did you implement your changes
Modify
watcher_callbacks.pyso that each callback first checks if the relevant files have been written. If so, simply return out. Allfov_watcher.pywill see is that these individual callbacks finished, thus allowing it to update properly.Remaining issues
Testing on a live cohort.