Include sources into p2-repository #215
Conversation
|
👍 This paves road for making tern.java extensions, is it so? |
|
@pascalleclercq could you please check this PR. Thanks! |
|
It makes developing tern.java extensions easier. When tern IUs declared in .target file eclipse can find sources and that lets debug/browse term.java sources without having them available in eclipse workspace. |
|
minimal-json has no sources and build fails to generate sources if it is included into feature.xml. I was able to workaround it by converting plug-in into requirement and including it directly into category.xml file. I did some tests with .target files using my local repo and tern.java IDE seems to work the same after installation. Would be good if someone would check it to confirm I didn't break something :) |
|
@dgolovin it means that when you install tern ide, you install too tern java sources? If it that I think it's shame to install tern sources too although users want sto just to use tern. To get sources, perhaps we should add link in the MANIFESTMF to the github. And after you do "Import" to download tern sources. What do you think about that? |
|
Sources are not installed by default unless you want them. They are separate features in "Tern Tooling Development Resources" category. They even can be uncategorized to draw less attention. We should add link to the git hub in manifests, but that different use case, when you use PDE Wizard to get sources from SCM. Including sources into p2-repository allows to use target platform definition and to have sources for debugging without any additional efforts, it just a matter to includeSources="true" attribute in . When source features installed it is possible to import sources into workspace offline with PDE "Import Plug-ins and Fragments" dialog when working offline. |
|
@angelozerr What about create wiki page "Developing tern.java" and add some compilation from here ? |
I have created the page at https://github.com/angelozerr/tern.java/wiki/Tern-Toolings-Development-Resources |
|
I have extended https://github.com/angelozerr/tern.java/wiki/Tern-Toolings-Development-Resources and tried to summarize. @dgolovin Could you please extend wiki, add some links and tell more e.g. about
|
|
@paulvi I added some info to article. There is no way to send PR for wiki, so I mirrored it and here is the link which compares latest revision in original wiki with my commit. https://github.com/dgolovin/tern.java-wiki/compare/2a3572d...master |
You cannot modify wiki pag eas you wish? @paulvi is able to change wiki pages. |
Include sources into p2-repository
|
This PR breaks now the build https://travis-ci.org/angelozerr/tern.java/builds/48020724 @dgolovin could you see the problem please. Do you think it's possible to see the problem quickly, because I would like to commit other features like ecma6. Thanks for your help. |
|
@dgolovin I'm waiting for your answer today. If I have not answer from you I will revert your PR. I will commit soon several features (like ecma6 support) and I would like to provide it quickly. Hoep you will understand. Thanks for your help! |
|
@angelozerr this build failure seems to be related to broken zip in local repository. It also marked with green check in PR closed PR list as 'Success: The Travis CI build passed'. |
Yes it's stange, but if you go at https://github.com/angelozerr/tern.java yopu will see that build icon travis is error. Have you an idea how to fix that? |
|
Last build is good :) |
Cool! Sorry for the noise. |
|
@dgolovin |
|
@dgolovin we have released tern.java + AngularJS Eclipse, but I have a problem when I try to update marketplace https://marketplace.eclipse.org/content/tern-eclipse-ide with minimal-json. Now minimal-json is not a feature bu a bundle. I can add features in marketplace but not bundle. So marketplace doesn't work -( Do you know how I could fix that please? Thanks! |
|
Can you not just add the minimal-json bundle into one of your feature.xml On Wed, Jan 28, 2015 at 4:37 PM, Angelo notifications@github.com wrote:
Greg Amerson |
|
Yes, minimal-json should be just a dependency of some feature and Eclipse will resolve to get it. Having it as separate item that user has to select is error prone. |
|
Ok problem is now fixed. Problem cames from that bundle of minimal-json was not included in the update site. @pascalleclercq has fixed the problem and release for 0.8.0 works great now. Thanks @pascalleclercq ! |
No description provided.