Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update avatar_gdb.get_mappings() #28

Merged
merged 1 commit into from Aug 23, 2023
Merged

update avatar_gdb.get_mappings() #28

merged 1 commit into from Aug 23, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2023

In the new version of gdb-multiarch (13.1), self.target.protocols.memory.get_mappings() returns an additional attribute Perms, which causes the current avatar_gdb.get_mappings() function to fail to obtain map_name correctly.

old:
image

new:
image

So I added some code in avatar_gdb.get_mappings() function to get Perms and map_name correctly and modified class MemoryMap accordingly.

old:
image

new:
image

@degrigis
Copy link
Member

This totally slipped under my radar, thanks!

@AndrewFasano
Copy link
Contributor

AndrewFasano commented Aug 28, 2023

Looks like this change breaks the panda target which creates creating MemoryMap objects here without setting a value for permission.

Are these permissions actually used somewhere? if so we can expand the panda target to specify this information. Otherwise maybe we could just allow perms to be None here?

EDIT: I think I'm getting a better understanding of this now - the change to the MemoryMap object was required, so we can't just leave it as None. I think Zak's PR fixes this for the PANDA target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants