Skip to content

Commit c24cba8

Browse files
jitsrainerhahnekamp
authored andcommitted
chore: switch to pnpm (for local dev)
Closes #73
1 parent bd8cb25 commit c24cba8

File tree

11 files changed

+17550
-12948
lines changed

11 files changed

+17550
-12948
lines changed

.github/workflows/build.yml

+9-6
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,17 @@ on:
88
- main
99
jobs:
1010
build:
11-
runs-on: ubuntu-latest
11+
runs-on: ubuntu-22.04
1212
steps:
13-
- uses: actions/checkout@v3
14-
- uses: actions/setup-node@v3
13+
- uses: actions/checkout@v4
14+
- uses: pnpm/action-setup@v4
15+
with:
16+
version: 9
17+
- uses: actions/setup-node@v4
1518
with:
1619
node-version: '18'
17-
cache: 'npm'
18-
- run: npx yarn
19-
- run: npm run build:all
20+
cache: "pnpm"
21+
- run: pnpm install --frozen-lockfile
22+
- run: pnpm run build:all
2023
- run: ./integration-tests.sh
2124

.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ testem.log
3838
.DS_Store
3939
Thumbs.db
4040

41-
.nx/cache
41+
.nx
4242
.angular
4343
/versions.txt

.prettierignore

+1
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@
33
/coverage
44
/.nx/cache
55
.angular
6+
pnpm-lock.yaml

README.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ export class FlightSearchDynamicComponent {
256256

257257
`withStorageSync` adds automatic or manual synchronization with Web Storage (`localstorage`/`sessionstorage`).
258258

259-
> [!WARNING]
259+
> [!WARNING]
260260
> As Web Storage only works in browser environments it will fallback to a stub implementation on server environments.
261261
262262
Example:
@@ -441,6 +441,8 @@ Since we don't want to bloat the library, we are very selective about new featur
441441
- A use case showing the feature in action in the demo app of the repository.
442442
- An entry to the README.md.
443443

444+
This project uses [pnpm](https://pnpm.io/) to manage dependencies and run tasks (for local development and CI).
445+
444446
### I require a feature that is not available in a lower version. What should I do?
445447

446448
Please create an issue. Very likely, we are able to cherry-pick the feature into the lower version.

apps/demo-e2e/playwright.config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default defineConfig({ ...nxE2EPreset(__filename, { testDir: './src' }),
2020
},
2121
/* Run your local dev server before starting the tests */
2222
webServer: {
23-
command: 'npx nx serve demo',
23+
command: 'pnpm nx serve demo',
2424
url: 'http://localhost:4200',
2525
reuseExistingServer: !process.env.CI,
2626
cwd: workspaceRoot,

integration-tests.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ do
1616
done < versions.txt
1717

1818
for version in ${versions[*]}; do
19-
npm i @ngrx/signals@$version
19+
pnpm i @ngrx/signals@$version
2020
echo "Building with version $version"
21-
npx nx build --project demo
21+
pnpm nx build --project demo
2222
done

libs/ngrx-toolkit/README.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ export class FlightSearchDynamicComponent {
256256

257257
`withStorageSync` adds automatic or manual synchronization with Web Storage (`localstorage`/`sessionstorage`).
258258

259-
> [!WARNING]
259+
> [!WARNING]
260260
> As Web Storage only works in browser environments it will fallback to a stub implementation on server environments.
261261
262262
Example:
@@ -434,13 +434,15 @@ To ensure stability, we clone these internal types and run integration tests for
434434

435435
### I have an idea for a new extension, can I contribute?
436436

437-
Yes, please! We are always looking for new ideas and contributions.
437+
Yes, please! We are always looking for new ideas and contributions.
438438

439439
Since we don't want to bloat the library, we are very selective about new features. You also have to provide the following:
440440
- Good test coverage so that we can update it properly and don't have to call you 😉.
441441
- A use case showing the feature in action in the demo app of the repository.
442442
- An entry to the README.md.
443443

444+
This project uses [pnpm](https://pnpm.io/) to manage dependencies and run tasks (for local development and CI).
445+
444446
### I require a feature that is not available in a lower version. What should I do?
445447

446448
Please create an issue. Very likely, we are able to cherry-pick the feature into the lower version.

nx.json

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"$schema": "./node_modules/nx/schemas/nx-schema.json",
3+
"packageManager": "pnpm",
34
"targetDefaults": {
45
"build": {
56
"cache": true,

package.json

+7-3
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,15 @@
33
"version": "0.0.0",
44
"license": "MIT",
55
"scripts": {
6-
"start": "npx nx serve demo",
7-
"build:all": "npx nx run-many --targets=build",
8-
"verify:all": "npx nx run-many --targets=lint,test,build"
6+
"start": "nx serve demo",
7+
"build:all": "nx run-many --targets=build",
8+
"verify:all": "nx run-many --targets=lint,test,build"
99
},
1010
"private": true,
11+
"engines": {
12+
"node": ">=18",
13+
"pnpm": "9"
14+
},
1115
"dependencies": {
1216
"@angular-architects/paper-design": "^1.0.3",
1317
"@angular/animations": "18.1.1",

0 commit comments

Comments
 (0)