Skip to content

Moving to pnpm #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rainerhahnekamp opened this issue Jul 25, 2024 · 2 comments · Fixed by #74
Closed

Moving to pnpm #73

rainerhahnekamp opened this issue Jul 25, 2024 · 2 comments · Fixed by #74
Assignees

Comments

@rainerhahnekamp
Copy link
Collaborator

Resulted from the following discussion with @jits, we want to give pnpm a try.


I find pnpm smoother (gut feel), after many years of using yarn (and I've switched over to pnpm for all Node.js based projects now).

A few concrete reasons why this might be the case:

  • performance — because pnpm uses symlinks to point your dependencies to a single source of truth on disk, it's very fast.
  • better dependency isolation — pnpm doesn't flatten the dependencies in the node_modules folder, so (in theory) provides a safer isolation between conflicting versions of sub-dependencies. It will still report conflicting versions though (so you can take action). My experience has been smoother in these situations with pnpm than yarn, where the latter would decide for you which version of the sub-dependency should be installed.
  • support — Yarn v1 (which is what npx yarn would fetch and use) has kinda been deprecated / is unsupported (https://github.com/yarnpkg/yarn?tab=readme-ov-file#%E2%84%B9%EF%B8%8F-important-note). It's not clear to me how long of a future it has. And the compatibility and migration story between v1 and subsequent versions isn't particularly smooth (https://yarnpkg.com/migration/guide). I've had annoying experiences migrating from Yarn v1 to a later version.
    • Whereas pnpm is gaining a lot of traction — e.g. it's the preferred choice in the Nuxt and unjs ecosystem.

I think I had a similar experience to you a few years back, but now it seems pnpm has matured quite a bit.

(https://refine.dev/blog/pnpm-vs-npm-and-yarn/ is a more detailed comparison, if you want to dig further)

Originally posted by @jits in #72 (comment)

@rainerhahnekamp
Copy link
Collaborator Author

@jits, can you take over here?

@jits
Copy link
Contributor

jits commented Jul 25, 2024

@rainerhahnekamp — will do, thanks. I'll put together a PR for consideration :)

jits added a commit to jits/ngrx-toolkit that referenced this issue Jul 25, 2024

Verified

This commit was signed with the committer’s verified signature.
lunny Lunny Xiao
@jits jits mentioned this issue Jul 25, 2024
2 tasks
jits added a commit to jits/ngrx-toolkit that referenced this issue Jul 26, 2024
jits added a commit to jits/ngrx-toolkit that referenced this issue Jul 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants