Skip to content

Switch to pnpm (for local dev) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jits
Copy link
Contributor

@jits jits commented Jul 25, 2024

Closes #73

I've verified that:

  • Running pnpm start works locally
  • Running pnpm build:all works locally
  • CI passes (using pnpm exclusively)
  • Caching works as expected in subsequent CI builds

Note: running pnpm verify:all causes some lint errors and a test error due to no test suite(s).


TODO:

  • Ensure CI passes
  • Update README(s?) to mention pnpm is used for local development

@jits
Copy link
Contributor Author

jits commented Jul 25, 2024

@rainerhahnekamp — for the README update (to mention pnpm is used for local development), I'm thinking of quickly mentioning it under the "I have an idea for a new extension, can I contribute?" FAQ entry. Does that work for you, for now? In the long run it may be worth having a dedicated CONTRIBUTING doc.

@rainerhahnekamp
Copy link
Collaborator

Thanks, and about the README, yeah sure, why not?

@jits jits force-pushed the switch-to-pnpm branch from 2bdb130 to e7e08ab Compare July 26, 2024 07:43
@jits jits marked this pull request as ready for review July 26, 2024 07:45
@jits
Copy link
Contributor Author

jits commented Jul 26, 2024

@rainerhahnekamp — ready for your review (when you have a sec) :)

@jits jits force-pushed the switch-to-pnpm branch from e7e08ab to 06b1b93 Compare July 26, 2024 07:50
Copy link
Collaborator

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the removal of nx

@rainerhahnekamp rainerhahnekamp merged commit c24cba8 into angular-architects:main Jul 26, 2024
1 check passed
@rainerhahnekamp
Copy link
Collaborator

Sorry, I will never understand this. I selected "rebase and merge" and GitHub states me as the committer. If you want I can rebase main to the former, you can create the same PR again, and I try a simple merge.

@jits
Copy link
Contributor Author

jits commented Jul 27, 2024

@rainerhahnekamp — that's not a problem at all — it shows as "jits authored and rainerhahnekamp committed" :)

@jits jits deleted the switch-to-pnpm branch July 27, 2024 12:13
@rainerhahnekamp
Copy link
Collaborator

Alright, then thanks a lot again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving to pnpm
2 participants