-
Notifications
You must be signed in to change notification settings - Fork 34
Switch to pnpm (for local dev) #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rainerhahnekamp — for the README update (to mention pnpm is used for local development), I'm thinking of quickly mentioning it under the "I have an idea for a new extension, can I contribute?" FAQ entry. Does that work for you, for now? In the long run it may be worth having a dedicated CONTRIBUTING doc. |
Thanks, and about the README, yeah sure, why not? |
@rainerhahnekamp — ready for your review (when you have a sec) :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about the removal of nx
Sorry, I will never understand this. I selected "rebase and merge" and GitHub states me as the committer. If you want I can rebase main to the former, you can create the same PR again, and I try a simple merge. |
@rainerhahnekamp — that's not a problem at all — it shows as "jits authored and rainerhahnekamp committed" :) |
Alright, then thanks a lot again. |
Closes #73
I've verified that:
pnpm start
works locallypnpm build:all
works locallyNote: running
pnpm verify:all
causes some lint errors and a test error due to no test suite(s).TODO: