Feature Request: Create injection token to replace "NgRx SignalStore" when calling connect

[mrentmeister-tt]

I would like to have the ability to configure the name of the application that appears in the Redux DevTools extension ("NgRx SignalStore"). Currently there isn't a way to change the name of the application after window.__REDUX_DEVTOOLS_EXTENSION__.connect is called. Since the DevtoolsSyncer already is an injectable service, please create an injection token that can be used to modify the app name when calling connect.

Example:

export const NGRX_DEVTOOLS_APPLICATION = new InjectionToken<string>('NgRxDevtoolsApplication');

[rainerhahnekamp]

Yes, we can do it via injection token, but we could also extend to withDevtools('flights', {devtoolsName: 'SignalStore'}). What is better?

[mrentmeister-tt]

I think I would prefer to do an injection token, so that you set it when you bootstrap your application. As far as I understand it, withDevtools defines a feature slice, rather than configuring the whole application. If put within withDevtools, what would happen if you have 2 conflicting devtoolsName passed by different stores?

[mrentmeister-tt]

Another option would be creating a function called something like provideDevtoolsConfig, that could be called when creating an application. It would be similar to https://ngrx.io/guide/store-devtools, and would allow you to set the name as part of the config.

[rainerhahnekamp]

Yes, so if it is going to be global, it should work via the provide* function

[rainerhahnekamp]

@mrentmeister-tt do you want to implement it?

[mikerentmeister]

switched to my other GH account, but yes, I will take a stab at a PR. I'll plan on implementing a provideDevtoolsConfig function, unless you'd rather I call it something else?

[mikerentmeister]

@rainerhahnekamp - I have finished the code for this feature. Can you please add this user as a collaborator so that I can publish the branch? Thanks!

[rainerhahnekamp]

Hey @mikerentmeister, at GitHub you usually fork this project to your own account and publish the branch there. GitHub is smart enough to to see that your forked repo has a new branch and offers you to create a PR right here. It is very easy.

So forking and pushing to your own repository, you navigate here https://github.com/angular-architects/ngrx-toolkit and GitHub asks you immediately if it should create the PR

[mikerentmeister]

@rainerhahnekamp - Thanks! PR submitted.