feat: Enhanced withCallState to accept mutliple collection configuration
#148
+66
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires additional changes and need to fix the typescript errors |
abhijit-chikane
force-pushed
the
main
branch
4 times, most recently
from
c74218f to
86baae1
Compare
abhijit-chikane
force-pushed
the
main
branch
from
86baae1 to
8b89c58
Compare
…ns with an array
…ation with backward compatibility
…ation with backward compatibility
…ation backward compatibility
…ns with an array
rainerhahnekamp
added
the
ready-for-review
|
@rainerhahnekamp did you get time to review this? |
rainerhahnekamp
requested changes
Mar 18, 2025
Well initially I did exactly that but then it would be a breaking change |
In which regard? To me, it would be an additional property. It would be breaking if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Enhanced
withCallStateto accept mutliple collection configurationFor #147
I have not tested it but happy to help if in case it didn't work as expected
thanks