reset only subset of the state in withReset()

[daboudii]

In case you need to re initialize your state

[rainerhahnekamp]

Thanks @daboudii, there is already an extension withReset. So I would suggest to use that one and if there is something missing, to make a PR for withReset.

I have to admit that I like your approach of using a function setInitial() in patchState much, much better than how it is implemented in withReset. So maybe that is something you could start with - if you want.

[daboudii]

The withReset do not meet my needs since it reset all the store and not just the callState, I implemented the setInitial() in this MR, is there anything more to add ?

[rainerhahnekamp]

@daboudii, yes what options do we have to do this in withReset()?

Would it help, if withReset() supports selecting a subset of the state?

The reason why I'm pushing for the integration in the other feature is that we would not be limited to support a very specific use case ( callState) but a much wider range.

[daboudii]

Ok get it, I will have a look

[daboudii]

@rainerhahnekamp let me know if it need something else

[abhijit-chikane]

Nice work🎉🎉 @daboudii
It would be even better if we could just reset the part of the slice
in case of obj sometimes we don't want to reset the whole inner object but part of the object

[daboudii]

Something like resetSlice('address.city') ? If yes it will add even more complexity, is it really necessary ?

[abhijit-chikane]

Something like resetSlice('address.city') ? If yes it will add even more complexity, is it really necessary ?

I think it will definitely add complexity but it will add much more value for project like ours and many others where data structures are much more complex

[daboudii]

I don't think I will add that, in this case just easier to patch your state with the value you which to change.

[rainerhahnekamp]

I touched upon that in my review below #160 (review)

[rainerhahnekamp]

Good job! I have a question about the design.

State changes would be better handled as functions within patchState. This ensures that patchState remains the sole entity modifying state and allows multiple update functions to run together as an “atomic update” of the internal Signal.

That being said, setResetState() was already implemented in a way that doesn’t align with this approach. What if we provide a more flexible reset() function that supports both full and partial state resets and is type-safe as well.

// reset the full state
patchState(store, reset())

// reset the partial state
patchState(store, reset(state => ({address: state.address, user: state.user}))

What do you say?

[daboudii]

What do you say?

Yes it looks way better like that ! I'm starting the rewrite