Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add withReset to sidenav + add imports to withReset #163

Merged

Conversation

michael-small
Copy link
Contributor

I saw withReset was not on the sidenav

Adjacent to the imports at the top of the page PR

  • I added an import like in the other PR but in this branch
  • Setting this as a draft as my open question in the imports PR applies to setResetState()

@daboudii
Copy link

There is the same issue with withCallState

@michael-small
Copy link
Contributor Author

The other docs PR where I added imports accidentally added withReset anyways, but this PR still will include addition to the sidenav so it still has a purpose.

@michael-small michael-small marked this pull request as ready for review March 19, 2025 02:36
@michael-small
Copy link
Contributor Author

I have marked this PR as ready.

With respect to @daboudii's point, I see there is not a dedicated docs page for withCallState. So in my opinion in relation to this PR, that's its own topic for a separate issue/PR of its own but thanks for pointing that out.

Copy link
Collaborator

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again.

@rainerhahnekamp rainerhahnekamp merged commit 6c498b3 into angular-architects:main Mar 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants