Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): only use livereload for development #1192

Merged
merged 1 commit into from
Aug 20, 2015

Conversation

Awk34
Copy link
Member

@Awk34 Awk34 commented Aug 19, 2015

No description provided.

@Awk34 Awk34 added this to the 3.0.0 milestone Aug 19, 2015
@@ -56,8 +56,11 @@ module.exports = function(app) {
app.use(morgan('dev'));
}

if ('development' === env || 'test' === env) {
if('development' === env) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSCS is failing b/c it wants a space between the if and the condition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, yeah. I'm not a fan of that rule.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Years of JS development have ingrained it in me...

@kingcody kingcody force-pushed the remove-livereload-from-test branch from afe1084 to 1855265 Compare August 20, 2015 08:50
kingcody added a commit that referenced this pull request Aug 20, 2015
fix(tests): only use livereload for development
@kingcody kingcody merged commit 4f4543e into canary Aug 20, 2015
@kingcody kingcody deleted the remove-livereload-from-test branch August 20, 2015 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants