Refactor/client types

[Awk34]

No description provided.

[Awk34]

@Koslun these changes should fix the TS errors and work in both TS/Flow

[Koslun]

@Awk34 Take it we're skipping more specific typings from definition files that would only apply to TS to avoid having a lot of ejs if's and thus more maintainable templates? Especially since many will be useless with Angular 2 with more maintainable templates also being a plus when we're upgrading.

[Awk34]

@Koslun I'm just trying to fix all the TS errors that people are seeing when building the app for the first time. I also want to try to keep any type definitions able to be used with both Flow & TS. Is that reasonable?

Also, is this good to merge?

[Koslun]

@Koslun I'm just trying to fix all the TS errors that people are seeing when building the app for the first time. I also want to try to keep any type definitions able to be used with both Flow & TS. Is that reasonable?

As I said. Appreciate that restricting type definitions to what works in both flow and TS enables us to avoid having either an extra template file or just a lot of if-statements for when it's TS. Also realize that most of TS-specific logic will be useless with Angular 1 anyway. With Angular 2 using external type definitions will also be needed to a much lesser extent as the Angular 2 libraries are already written in TS. So figure that fully typed TS and Flow code will be a lot more similar then.

So based on that premise I think it's fully reasonable and like the strategy.

If anything I'm more skeptical of Flow itself as it does not currently support definition files and I know no libraries written with Flow, would think React is but cannot find anything to indicate that. Can however somewhat understand wanting to rather work with Babel and thus using Flow with that. And as it's already implemented in this generator I can see the benefits of it.

Also, is this good to merge?

Pretty much, seems to work on my end. Might want to fix two final errors:

[default] project/client/components/auth/auth.service.ts:137:14
    Supplied parameters do not match any signature of call target.
[default] project/client/components/auth/auth.service.ts:162:14
    Supplied parameters do not match any signature of call target.

Looking into it now.

[Awk34]

would think React is

Yeah, React uses Flow.

[Koslun]

What I don't then get is why they don't clearly state that here: https://facebook.github.io/react/docs/language-tooling.html#flow , or even here: https://flowtype.org/docs/react.html#_. Feels like a pretty meaningful feature and a strong insentive to use Flow when you develop React applications. Not mentioned on React's wikipedia page either.

[Awk34]

@Koslun ¯_(ツ)_/¯

They have TypeScript typings, as well as test against TypeScript, CoffeeScript

[Koslun]

Shouldn't have changed any behavior just more explicitly sending in undefined, could also just send the functions in the then blocks too but opted to just add small note to documentation and change nothing really.

[Awk34]

"optional, " is redundant here

[Koslun]

Think the fail is unrelated, tried scaling back the changes and getting the same errors when running the tests locally.

[Awk34]

Sequelize likes to 💩 itself quite often