Fixed bug in chrome, which caused bootsrap buttons to have a of height of 33px instead of 34px #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of 34px Found cause and fix here: twbs/bootstrap-sass#409
|
Hi, thanks for the PR. But if you could, please submit to generator-angular so I can pull the change upstream. I'm trying to keep the client build code consistent with theirs as much as possible and focus on the server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I had a strange bug today in my chome browser which caused bootrap buttons to be 33px heigh instead of the usual 34px. After some research, I found out that its a know issue and can be fixed by increasing the the precision of the sass compiler.
Cheers,
Peer
Found cause and fix here:
twbs/bootstrap-sass#409
gruntjs/grunt-contrib-compass#113