Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grunt-protractor-runner from 0.2.4 to 1.1.0 #400

Merged
merged 1 commit into from
Jul 30, 2014
Merged

Update grunt-protractor-runner from 0.2.4 to 1.1.0 #400

merged 1 commit into from
Jul 30, 2014

Conversation

matthewrankin
Copy link
Contributor

Protractor v1.0.0 has been released. To take advantage of this, we need to update grunt-protractor-runner to version 1.1.0.

All tests from npm test passed, although I didn't add any new tests. Also, I confirmed that after scaffolding out a new project, the following passed successfully:

$ mongod --config /usr/local/etc/mongod.conf
// New shell
$ grunt test:server
$ grunt test:client
$ npm run update-webdriver
$ grunt test:e2e

Notes:

  1. When I scaffolded out the project, I accepted all defaults.
  2. I do not have protractor installed globally.
  3. In a separate shell, I ran mongod --config /usr/local/etc/mongod.conf to get MongoDB running since I'm on OS X and installed it using Homebrew.

@DaftMonk
Copy link
Member

Could you update the commit message to match the contributing guidelines? https://github.com/DaftMonk/generator-angular-fullstack/blob/master/contributing.md

Update grunt-protractor-runner from 0.2.4 to 1.1.0 to take advantage of
Protractor 1.0.0 being released.
@matthewrankin
Copy link
Contributor Author

@DaftMonk Sorry about that. Is that better?

DaftMonk added a commit that referenced this pull request Jul 30, 2014
…nner

Update grunt-protractor-runner from 0.2.4 to 1.1.0
@DaftMonk DaftMonk merged commit 4000c4a into angular-fullstack:master Jul 30, 2014
@matthewrankin matthewrankin deleted the update-grunt-protrcator-runner branch July 30, 2014 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants