feat(connector): allow override of stateSliceEqualityComparer #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for great job, ng-redux is a first class tool to move away from AngularJS service based state applications to a more robust state management solution.
In a large scale legacy application we started to refactor the whole app using ng-redux and are now facing a performance issue due to an increasing
$digest
cycle time.We noticed the
updateTarget
method was called because the providedshallowEqual
does not exactly fit our model shape. Please see below a sample component.Motivation:
The goal of this PR is to allow to override the default
shallowEqual
implementation atconnect
time and at component level.