Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support added for angular 17 #175

Merged
merged 1 commit into from
Jan 25, 2024
Merged

support added for angular 17 #175

merged 1 commit into from
Jan 25, 2024

Conversation

irsali
Copy link
Contributor

@irsali irsali commented Dec 16, 2023

No description provided.

@fmalcher
Copy link
Member

Thanks for your PR! However, adding support for Angular 17 is more than increasing the version number, unfortunately.
The new application builder has a different output directory, so we need to make it more configurable. See #173

@JohannesHoppe JohannesHoppe merged commit 56b2bd7 into angular-schule:main Jan 25, 2024
@JohannesHoppe
Copy link
Member

Fixed in angular-cli-ghpages@2.0.0-beta. Please try out this version and give me feedback, so that I can mark it as stable and publish it as the latest version. This new version uses conventions to figure out the best buildTarget and uses the browser folder by default. The browser folder can be configured as described here.

See #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irsali @fmalcher @JohannesHoppe @noble-wave