Skip to content

Commit dacb898

Browse files
author
Valentin Hervieu
committed
Revert "fix(onStart): Remove stop propagation call so events will bubble up (#612)"
This reverts commit 65a7fae.
1 parent a1ba079 commit dacb898

10 files changed

+465
-431
lines changed

‎dist/rzslider.css

+10-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/rzslider.js

+416-415
Large diffs are not rendered by default.

‎dist/rzslider.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/rzslider.min.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/rzslider.scss

+10-6
Large diffs are not rendered by default.

‎src/rzslider.js

+1
Original file line numberDiff line numberDiff line change
@@ -1953,6 +1953,7 @@
19531953
ehEnd,
19541954
eventNames = this.getEventNames(event)
19551955

1956+
event.stopPropagation()
19561957
event.preventDefault()
19571958

19581959
// We have to do this in case the HTML where the sliders are on

‎tests/specs/mouse-controls/range-slider-horizontal-test.js

+8
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
helper.slider.callOnStart.called.should.be.true
4747
helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
4848
event.preventDefault.called.should.be.true
49+
event.stopPropagation.called.should.be.true
4950
expect(helper.slider.tracking).to.equal('lowValue')
5051
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
5152
})
@@ -64,6 +65,7 @@
6465
helper.slider.callOnStart.called.should.be.true
6566
helper.slider.focusElement.called.should.be.false
6667
event.preventDefault.called.should.be.true
68+
event.stopPropagation.called.should.be.true
6769
expect(helper.slider.tracking).to.equal('lowValue')
6870
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
6971
})
@@ -79,6 +81,7 @@
7981
helper.slider.callOnStart.called.should.be.true
8082
helper.slider.focusElement.calledWith(helper.slider.maxH).should.be.true
8183
event.preventDefault.called.should.be.true
84+
event.stopPropagation.called.should.be.true
8285
expect(helper.slider.tracking).to.equal('highValue')
8386
expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
8487
})
@@ -97,6 +100,7 @@
97100
helper.slider.callOnStart.called.should.be.true
98101
helper.slider.focusElement.called.should.be.false
99102
event.preventDefault.called.should.be.true
103+
event.stopPropagation.called.should.be.true
100104
expect(helper.slider.tracking).to.equal('highValue')
101105
expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
102106
})
@@ -308,6 +312,7 @@
308312
helper.slider.callOnStart.called.should.be.true
309313
helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
310314
event.preventDefault.called.should.be.true
315+
event.stopPropagation.called.should.be.true
311316
expect(helper.slider.tracking).to.equal('lowValue')
312317
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
313318
})
@@ -326,6 +331,7 @@
326331
helper.slider.callOnStart.called.should.be.true
327332
helper.slider.focusElement.called.should.be.false
328333
event.preventDefault.called.should.be.true
334+
event.stopPropagation.called.should.be.true
329335
expect(helper.slider.tracking).to.equal('lowValue')
330336
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
331337
})
@@ -341,6 +347,7 @@
341347
helper.slider.callOnStart.called.should.be.true
342348
helper.slider.focusElement.calledWith(helper.slider.maxH).should.be.true
343349
event.preventDefault.called.should.be.true
350+
event.stopPropagation.called.should.be.true
344351
expect(helper.slider.tracking).to.equal('highValue')
345352
expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
346353
})
@@ -359,6 +366,7 @@
359366
helper.slider.callOnStart.called.should.be.true
360367
helper.slider.focusElement.called.should.be.false
361368
event.preventDefault.called.should.be.true
369+
event.stopPropagation.called.should.be.true
362370
expect(helper.slider.tracking).to.equal('highValue')
363371
expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
364372
})

‎tests/specs/mouse-controls/range-slider-vertical-test.js

+8
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
helper.slider.callOnStart.called.should.be.true
4848
helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
4949
event.preventDefault.called.should.be.true
50+
event.stopPropagation.called.should.be.true
5051
expect(helper.slider.tracking).to.equal('lowValue')
5152
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
5253
})
@@ -65,6 +66,7 @@
6566
helper.slider.callOnStart.called.should.be.true
6667
helper.slider.focusElement.called.should.be.false
6768
event.preventDefault.called.should.be.true
69+
event.stopPropagation.called.should.be.true
6870
expect(helper.slider.tracking).to.equal('lowValue')
6971
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
7072
})
@@ -80,6 +82,7 @@
8082
helper.slider.callOnStart.called.should.be.true
8183
helper.slider.focusElement.calledWith(helper.slider.maxH).should.be.true
8284
event.preventDefault.called.should.be.true
85+
event.stopPropagation.called.should.be.true
8386
expect(helper.slider.tracking).to.equal('highValue')
8487
expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
8588
})
@@ -98,6 +101,7 @@
98101
helper.slider.callOnStart.called.should.be.true
99102
helper.slider.focusElement.called.should.be.false
100103
event.preventDefault.called.should.be.true
104+
event.stopPropagation.called.should.be.true
101105
expect(helper.slider.tracking).to.equal('highValue')
102106
expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
103107
})
@@ -302,6 +306,7 @@
302306
helper.slider.callOnStart.called.should.be.true
303307
helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
304308
event.preventDefault.called.should.be.true
309+
event.stopPropagation.called.should.be.true
305310
expect(helper.slider.tracking).to.equal('lowValue')
306311
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
307312
})
@@ -320,6 +325,7 @@
320325
helper.slider.callOnStart.called.should.be.true
321326
helper.slider.focusElement.called.should.be.false
322327
event.preventDefault.called.should.be.true
328+
event.stopPropagation.called.should.be.true
323329
expect(helper.slider.tracking).to.equal('lowValue')
324330
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
325331
})
@@ -335,6 +341,7 @@
335341
helper.slider.callOnStart.called.should.be.true
336342
helper.slider.focusElement.calledWith(helper.slider.maxH).should.be.true
337343
event.preventDefault.called.should.be.true
344+
event.stopPropagation.called.should.be.true
338345
expect(helper.slider.tracking).to.equal('highValue')
339346
expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
340347
})
@@ -353,6 +360,7 @@
353360
helper.slider.callOnStart.called.should.be.true
354361
helper.slider.focusElement.called.should.be.false
355362
event.preventDefault.called.should.be.true
363+
event.stopPropagation.called.should.be.true
356364
expect(helper.slider.tracking).to.equal('highValue')
357365
expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
358366
})

‎tests/specs/mouse-controls/single-slider-horizontal-test.js

+4
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
helper.slider.callOnStart.called.should.be.true
4646
helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
4747
event.preventDefault.called.should.be.true
48+
event.stopPropagation.called.should.be.true
4849
expect(helper.slider.tracking).to.equal('lowValue')
4950
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
5051
})
@@ -63,6 +64,7 @@
6364
helper.slider.callOnStart.called.should.be.true
6465
helper.slider.focusElement.called.should.be.false
6566
event.preventDefault.called.should.be.true
67+
event.stopPropagation.called.should.be.true
6668
expect(helper.slider.tracking).to.equal('lowValue')
6769
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
6870
})
@@ -247,6 +249,7 @@
247249
helper.slider.callOnStart.called.should.be.true
248250
helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
249251
event.preventDefault.called.should.be.true
252+
event.stopPropagation.called.should.be.true
250253
expect(helper.slider.tracking).to.equal('lowValue')
251254
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
252255
})
@@ -265,6 +268,7 @@
265268
helper.slider.callOnStart.called.should.be.true
266269
helper.slider.focusElement.called.should.be.false
267270
event.preventDefault.called.should.be.true
271+
event.stopPropagation.called.should.be.true
268272
expect(helper.slider.tracking).to.equal('lowValue')
269273
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
270274
})

‎tests/specs/mouse-controls/single-slider-vertical-test.js

+4
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
helper.slider.callOnStart.called.should.be.true
4747
helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
4848
event.preventDefault.called.should.be.true
49+
event.stopPropagation.called.should.be.true
4950
expect(helper.slider.tracking).to.equal('lowValue')
5051
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
5152
})
@@ -64,6 +65,7 @@
6465
helper.slider.callOnStart.called.should.be.true
6566
helper.slider.focusElement.called.should.be.false
6667
event.preventDefault.called.should.be.true
68+
event.stopPropagation.called.should.be.true
6769
expect(helper.slider.tracking).to.equal('lowValue')
6870
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
6971
})
@@ -266,6 +268,7 @@
266268
helper.slider.callOnStart.called.should.be.true
267269
helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
268270
event.preventDefault.called.should.be.true
271+
event.stopPropagation.called.should.be.true
269272
expect(helper.slider.tracking).to.equal('lowValue')
270273
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
271274
})
@@ -284,6 +287,7 @@
284287
helper.slider.callOnStart.called.should.be.true
285288
helper.slider.focusElement.called.should.be.false
286289
event.preventDefault.called.should.be.true
290+
event.stopPropagation.called.should.be.true
287291
expect(helper.slider.tracking).to.equal('lowValue')
288292
expect(helper.slider.minH.hasClass('rz-active')).to.be.true
289293
})

0 commit comments

Comments
 (0)