Skip to content

fix(onStart): Remove stop propagation call so events will bubble up #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2018
Merged

fix(onStart): Remove stop propagation call so events will bubble up #612

merged 1 commit into from
Jan 24, 2018

Conversation

andreeib
Copy link
Contributor

Closes #611

@codecov-io
Copy link

Codecov Report

Merging #612 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #612   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         950    949    -1     
=====================================
- Hits          950    949    -1
Impacted Files Coverage Δ
src/rzslider.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 698f927...9a8be6c. Read the comment docs.

@ValentinH
Copy link
Member

Thanks! :)

@ValentinH ValentinH merged commit 65a7fae into angular-slider:master Jan 24, 2018
@stripathix
Copy link

In ionic, there is an event attached to swipe left/right to show/hide side menu. Removing event.stopPropagation() on start causes opening of side menu when the slider is dragged to right. There can be many different cases or framework which has an event attached to swipe especially for mobile application, I am not sure removing event.stopPropagation() from the library was a good idea because now every developer who uses this library for mobile apps will have to write onStart option to ensure event.stopPropagation(); to prevent side menu from opening.

To solve this I have added an option for slider configuration.

options: { onStart: function () { event.stopPropagation(); }, }

@stripathix
Copy link

Adding onStart as an option does not solve this issue of side menu opening. Rolling back to 6.4.3 :-(

@andreeib andreeib deleted the remove-stop-propagation branch March 19, 2018 09:32
ValentinH pushed a commit that referenced this pull request Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants